Deprecate tuple-like access to CircuitInstruction
#12640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
Changelog: Deprecation
|
One or more of the following people are relevant to this code:
|
This has been the legacy path since `CircuitInstruction` was added in Qiskitgh-8093. It's more performant to use the attribute-access patterns, and with more of the internals moving to Rust and potentially needing more use of additional class methods and attributes, we need to start shifting people away from the old form.
jakelishman
force-pushed
the
deprecate-legacy-instruction-iterable
branch
from
29980c1 to
9a08838
Compare
Pull Request Test Coverage Report for Build 9617201737Details
💛 - Coveralls |
mtreinish
approved these changes
Jun 24, 2024
Comment on lines
+967
to
+969
| // Stack level. Compared to Python-space calls to `warn`, this is unusually low | ||
| // beacuse all our internal call structure is now Rust-space and invisible to Python. | ||
| 1, |
There was a problem hiding this comment.
This isn't great, but yeah there isn't really an alternative because the call stack isn't really accessible here.
There was a problem hiding this comment.
tbh, I think it might actually work out better from Rust space than it otherwise would, because this is only called by magic methods, which have weird callstacks already, since some of the "logical" parts of it are CPython internals already.
Setting stacklevel=1 here causes everything I could think of to get blamed on the actual triggering line in Python space.
|
I think, randomized tests is still using this deprecated behavior https://github.com/Qiskit/qiskit/actions/runs/9656096284/job/26633022278 |
1ucian0
added a commit
to 1ucian0/qiskit-terra
that referenced
this pull request
Jun 26, 2024
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
This has been the legacy path since `CircuitInstruction` was added in Qiskitgh-8093. It's more performant to use the attribute-access patterns, and with more of the internals moving to Rust and potentially needing more use of additional class methods and attributes, we need to start shifting people away from the old form.
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
… (Qiskit#12663) * addapting to Qiskit#12640 * more instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has been the legacy path since
CircuitInstructionwas added in gh-8093. It's more performant to use the attribute-access patterns, and with more of the internals moving to Rust and potentially needing more use of additional class methods and attributes, we need to start shifting people away from the old form.Details and comments
Fix #12631.
The sister PR to Aer that fixes its remaining uses of this is Qiskit/qiskit-aer#2179.