Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapting test/randomized/test_transpiler_equivalence.py to #12640 #12663

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jun 26, 2024

Summary

Randomized testing is failing because is calling deprecated functionality (introduced in #12640)

Details and comments

#2645 (comment)

@1ucian0 1ucian0 added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jun 26, 2024
@1ucian0 1ucian0 requested a review from a team as a code owner June 26, 2024 08:30
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

ElePT
ElePT previously approved these changes Jun 26, 2024
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT enabled auto-merge June 26, 2024 08:34
@1ucian0
Copy link
Member Author

1ucian0 commented Jun 26, 2024

LGTM

I found more instances... you are just too fast :)

@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9676522395

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 89.772%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
qiskit/synthesis/discrete_basis/solovay_kitaev.py 4 94.74%
crates/qasm2/src/lex.rs 4 92.37%
Totals Coverage Status
Change from base Build 9661630219: 0.05%
Covered Lines: 63792
Relevant Lines: 71060

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jun 26, 2024
Merged via the queue into Qiskit:main with commit 26680dc Jun 26, 2024
15 checks passed
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants