-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md
typo & manual QA
#13669
README.md
typo & manual QA
#13669
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 12805552412Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added a few minor suggestions, but I am doubting the use of "Sampler" vs "the Sampler".... I don't know if we will ever achieve consistency :)
|
||
Create an example quantum circuit using the `QuantumCircuit` class: | ||
|
||
```python | ||
import numpy as np | ||
from qiskit import QuantumCircuit | ||
|
||
# 1. A quantum circuit for preparing the quantum state |000> + i |111> | ||
qc_example = QuantumCircuit(3) | ||
qc_example.h(0) # generate superpostion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha superpostion, it sounds like a superhero name
Co-authored-by: Elena Peña Tapia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport stable/1.3 |
✅ Backports have been created
|
* Put yourself in `black`s shoes and look at the readme * Apply suggestions from code review Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 39db0c7)
* Put yourself in `black`s shoes and look at the readme * Apply suggestions from code review Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 39db0c7) Co-authored-by: Julien Gacon <[email protected]>
Summary
Fix a typo and apply some manual quality assurance such that the example code matches our formatting. Also "primitive functions" are rather referred to as primitives (see e.g. https://docs.quantum.ibm.com/api/qiskit/primitives), it would be nice to be a bit more consistent.