Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md typo & manual QA (backport #13669) #13674

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2025

Summary

Fix a typo and apply some manual quality assurance such that the example code matches our formatting. Also "primitive functions" are rather referred to as primitives (see e.g. https://docs.quantum.ibm.com/api/qiskit/primitives), it would be nice to be a bit more consistent.


This is an automatic backport of pull request #13669 done by [Mergify](https://mergify.com).

* Put yourself in `black`s shoes and look at the readme

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <[email protected]>

---------

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 39db0c7)
@mergify mergify bot requested a review from a team as a code owner January 16, 2025 12:04
@mergify mergify bot mentioned this pull request Jan 16, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: None Do not include in changelog label Jan 16, 2025
@github-actions github-actions bot added this to the 2.0.0 milestone Jan 16, 2025
@ElePT ElePT enabled auto-merge January 16, 2025 12:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12808451579

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.924%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 91.96%
crates/accelerate/src/unitary_synthesis.rs 1 93.21%
crates/qasm2/src/lex.rs 5 92.73%
Totals Coverage Status
Change from base Build 12773237073: 0.01%
Covered Lines: 79171
Relevant Lines: 89032

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jan 16, 2025
Merged via the queue into stable/1.3 with commit 5c6cfe1 Jan 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants