Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The unused parameter dag in DAGNode constructor is deprecated #13862

Merged
merged 7 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions qiskit/dagcircuit/dagnode.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import typing
import uuid
import warnings

import qiskit._accelerate.circuit
from qiskit.circuit import (
Expand All @@ -34,10 +35,25 @@
from qiskit.dagcircuit import DAGCircuit


DAGNode = qiskit._accelerate.circuit.DAGNode
DAGOpNode = qiskit._accelerate.circuit.DAGOpNode
DAGInNode = qiskit._accelerate.circuit.DAGInNode
DAGOutNode = qiskit._accelerate.circuit.DAGOutNode
def __init__wrapper__(func):
def wrapper(*args, **kwargs):
if "dag" in kwargs:
warnings.warn(
f"The 'dag' parameter in {func.__module__}.{func.__qualname__} "
"constructor is unused and it will be removed in Qiskit 2.0.",
category=DeprecationWarning,
stacklevel=2,
)
res = func(*args, **kwargs)
return res

return wrapper


DAGNode = __init__wrapper__(qiskit._accelerate.circuit.DAGNode)
DAGOpNode = __init__wrapper__(qiskit._accelerate.circuit.DAGOpNode)
DAGInNode = __init__wrapper__(qiskit._accelerate.circuit.DAGInNode)
DAGOutNode = __init__wrapper__(qiskit._accelerate.circuit.DAGOutNode)


def _legacy_condition_eq(cond1, cond2, bit_indices1, bit_indices2) -> bool:
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/deprecation_13022-9cf84f6c5ff13b29.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
deprecations_circuits:
- |
The ``DAGNode`` subclasses take a ``dag`` optional parameter when constructed that is currently unused and ignored. Now it is deprecated and will be removed in Qiskit 2.0
Loading