The unused parameter dag in DAGNode constructor is deprecated

[1ucian0]

Summary

Fixes #13022

Details and comments

Because qiskit._accelerate.circuit.DAGNode (and family) are rust implementations, I had to write a custom decorator wrapper for them.

[qiskit-bot]

One or more of the following people are relevant to this code:

• @Qiskit/terra-core

[mtreinish]

I'm pretty sure this approach won't work. It changes the semantics around the DAG node types and will break a lot of the usage around the classes. It should be pretty easy to emit the deprecation warning from rust though, here is an example of calling python's warning from rust:

qiskit/crates/circuit/src/dag_circuit.rs

Lines 407 to 419 in 581dd3d

	fn get_duration(&self, py: Python) -> PyResult<Option<Py<PyAny>>> {
	imports::WARNINGS_WARN.get_bound(py).call1((
	intern!(
	py,
	concat!(
	"The property ``qiskit.dagcircuit.dagcircuit.DAGCircuit.duration`` is ",
	"deprecated as of Qiskit 1.3.0. It will be removed in Qiskit 2.0.0.",
	)
	),
	py.get_type::<PyDeprecationWarning>(),
	2,
	))?;
	Ok(self.duration.as_ref().map(|x| x.clone_ref(py)))

We can just wrap that in an if dag.is_some() for the dag node constructor and that should cover it.

[1ucian0]

I saw your message about raising from rust too late and I implemented in python overwriting __init__ in e51cf2c. Not very elegant. What do you think?

[qiskit-bot]

One or more of the following people are relevant to this code:

• @Qiskit/terra-core

[mtreinish]

I saw your message about raising from rust too late and I implemented in python overwriting __init__ in e51cf2c. Not very elegant. What do you think?

I think we should probably add it in rust. It's a lot simpler and less error prone..

[1ucian0]

done in b6426fc . Easier than expected and much more correct. Thanks for the rusty push :)

[qiskit-bot]

One or more of the following people are relevant to this code:

• @Qiskit/terra-core

[ElePT]

LGTM!