Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The unused parameter dag in DAGNode constructor is removed #13863

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 17, 2025

Summary

Removal of the deprecation from #13862 . Therefore, on hold until the deprecation is merged in 1.4

@1ucian0 1ucian0 requested a review from a team as a code owner February 17, 2025 17:06
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added this to the 2.0.0 milestone Feb 17, 2025
@coveralls
Copy link

coveralls commented Feb 17, 2025

Pull Request Test Coverage Report for Build 13498664887

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 605 unchanged lines in 29 files lost coverage.
  • Overall coverage decreased (-0.1%) to 88.13%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/basis/basis_translator/basis_search.rs 1 99.31%
crates/accelerate/src/basis/basis_translator/compose_transforms.rs 1 99.16%
crates/accelerate/src/two_qubit_decompose.rs 1 91.82%
crates/circuit/src/dag_circuit.rs 1 87.6%
qiskit/providers/models/backendproperties.py 1 94.74%
qiskit/transpiler/passmanager_config.py 1 98.55%
crates/qasm2/src/lex.rs 2 92.98%
crates/circuit/src/dag_node.rs 3 77.39%
qiskit/transpiler/passes/layout/dense_layout.py 3 96.34%
qiskit/transpiler/passes/layout/vf2_utils.py 4 97.22%
Totals Coverage Status
Change from base Build 13336190323: -0.1%
Covered Lines: 78403
Relevant Lines: 88963

💛 - Coveralls

@mtreinish mtreinish enabled auto-merge February 24, 2025 13:02
@mtreinish mtreinish added Changelog: Removal Include in the Removed section of the changelog Rust This PR or issue is related to Rust code in the repository labels Feb 24, 2025
@mtreinish mtreinish added this pull request to the merge queue Feb 24, 2025
@mtreinish mtreinish removed this pull request from the merge queue due to a manual request Feb 24, 2025
@mtreinish mtreinish added this pull request to the merge queue Feb 24, 2025
Merged via the queue into Qiskit:main with commit cc64dd7 Feb 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants