Each thread needs its own passmanager #4003
Merged
+52
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
ajavadia,
kdk,
lcapelluto,
mtreinish and
taalexander
as code owners
1ucian0
added
the
Changelog: Bugfix
lcapelluto
pushed a commit
to lcapelluto/qiskit-terra
that referenced
this pull request
Mar 25, 2020
* we already have this problem solved in the passmanager * test * lint * release note * reduce diff * windows support * removing the timeout
1ucian0
pushed a commit
to 1ucian0/qiskit-terra
that referenced
this pull request
Apr 1, 2020
mergify bot
added a commit
that referenced
this pull request
Apr 2, 2020
…them silently (#4060) * #4003 (review) * cast circuit parameter as a list sooner than later * multiple circuits for passmanager.run * remove pass_manager from the transpile_args * set default optimization in a single place * conflicting args * lint * reno * lint! * empty pass manager is a pass manager * other redundant param * deprecate parameter * remove deprecated tranpile call from test.python.transpiler * remove deprecated tranpile call from test.python.compiler * last fix * unsed import * test/python/circuit/test_unitary.py * unused import * execute * lint * reno Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* we already have this problem solved in the passmanager * test * lint * release note * reduce diff * windows support * removing the timeout
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…them silently (Qiskit#4060) * Qiskit#4003 (review) * cast circuit parameter as a list sooner than later * multiple circuits for passmanager.run * remove pass_manager from the transpile_args * set default optimization in a single place * conflicting args * lint * reno * lint! * empty pass manager is a pass manager * other redundant param * deprecate parameter * remove deprecated tranpile call from test.python.transpiler * remove deprecated tranpile call from test.python.compiler * last fix * unsed import * test/python/circuit/test_unitary.py * unused import * execute * lint * reno Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3925
The problem in #3925 is that a deadlock in the passmanager space. This caa5eff fixes that in a very bold way. The @itoko example from #3925 with this fix can run, but ignores the
backendparameter. I'm not sure what it should do there.This PR is a draft, because I would like to refactor this full parallel/argument-prioritization.