Transpiler should raise when conflicting parameters, not just ignore them silently

[1ucian0]

If transpile is called with pass_manager, most of the additional parameters are already embed in the pass manager configuration and they are currently silently ignored.

This PR raises when that happen and includes a small refactor to reorganize the code.

[ajavadia]

can we just remove the pass_manager kwarg from transpile(circuit, pass_manager)? it's no different than pass_manager.run(circuit). It was only included temporarily for backwards compatibility, but if you already have the passmanager you shouldn't have to call transpile. The transpile function is there to select an appropriate passmanager based on some desired transpilation criteria.

This is in the docstring:

        pass_manager: The pass manager to use for a custom pipeline of transpiler passes.
            If this arg is present, all other args will be ignored and the
            pass manager will be used directly (Qiskit will not attempt to
            auto-select a pass manager based on transpile options).

[1ucian0]

can we just remove the pass_manager kwarg from transpile(circuit, pass_manager)? it's no different than pass_manager.run(circuit). It was only included temporarily for backwards compatibility, but if you already have the passmanager you shouldn't have to call transpile. The transpile function is there to select an appropriate passmanager based on some desired transpilation criteria.

Agree. Let's depreate the parameter in this PR too!