Command/Inst refactor: tidy up and complete deprecations #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…The Play instruction takes a Pulse and a PulseChannel. Pulse is a new class within the pulse library that is very close to the deprecated PulseCommand abstract class. The PulseCommand implementations (SamplePulse and the ParametricPulse subclasses) have been moved to the pulse library as well, subclassing from Pulse, and all valid arguments to Play.
…can't import Pulse from Play (for typehints) for the timebeing
…hash and eq methods to pulses
…he new Pulse class
… migrated ParametricPulses module. Moved the drag pulse docstring over finally
|
Weakly blocked on #3936 |
Co-Authored-By: eggerdj <[email protected]>
Co-Authored-By: eggerdj <[email protected]>
Co-Authored-By: eggerdj <[email protected]>
…a29d3.yaml Co-Authored-By: eggerdj <[email protected]>
| # implemented, because they do not have an operands method. | ||
| if self.command is None: | ||
| raise NotImplementedError | ||
|
|
There was a problem hiding this comment.
does this return None of (,) ? same for the .command
There was a problem hiding this comment.
no return is the same as return None
* we already have this problem solved in the passmanager * test * lint * release note * reduce diff * windows support * removing the timeout
…s a tuple rather than a list, fix bug in kernel and discriminator repr, general clean up of Instructions
…t must be used in the assembler. It will be easy to deprecate and remove in a few months
lcapelluto
force-pushed
the
issue-3750-wrap-up
branch
from
b894948 to
97fa7bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 7/7 for issue #3750 !
Waiting on #3936!
Details and comments
TODO: