-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke pip install
by module not executable
#9972
Conversation
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use `python -m pip install ...` than `pip install`. We have seen some CI failures on Windows due to `pip` failing to update itself because of the direct-executable `pip install` form.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4715313887
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM primarily because CI passed. TBH, I'm not convinced it's an OS limitation but more that the pip maintainers changed and/or broke something, as there was a new release published on Saturday:
https://pypi.org/project/pip/23.1/
But calling via module everywhere works fine, even if the issue in pip is fixed eventually.
I'm fairly sure it is a Windows limitation - the only line that did |
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use `python -m pip install ...` than `pip install`. We have seen some CI failures on Windows due to `pip` failing to update itself because of the direct-executable `pip install` form. (cherry picked from commit 51fdb3c) # Conflicts: # .azure/lint-linux.yml # .azure/test-linux.yml # .azure/test-macos.yml # .azure/test-windows.yml # .azure/tutorials-linux.yml # .github/workflows/coverage.yml # .github/workflows/randomized_tests.yml # .github/workflows/slow.yml
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use `python -m pip install ...` than `pip install`. We have seen some CI failures on Windows due to `pip` failing to update itself because of the direct-executable `pip install` form. (cherry picked from commit 51fdb3c)
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use `python -m pip install ...` than `pip install`. We have seen some CI failures on Windows due to `pip` failing to update itself because of the direct-executable `pip install` form. (cherry picked from commit 51fdb3c) Co-authored-by: Jake Lishman <[email protected]>
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use `python -m pip install ...` than `pip install`. We have seen some CI failures on Windows due to `pip` failing to update itself because of the direct-executable `pip install` form.
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use `python -m pip install ...` than `pip install`. We have seen some CI failures on Windows due to `pip` failing to update itself because of the direct-executable `pip install` form.
Summary
On some OSes and configurations (usually Windows), there can be problems when a binary attempts to one that is in use, especially itself. For this reason, it is more reliable to use
python -m pip install ...
thanpip install
. We have seen some CI failures on Windows due topip
failing to update itself because of the direct-executablepip install
form.Details and comments