fix(ingestion/powerbi): Not all arguments converted to string (datahu…

…b-project#7157)

Co-authored-by: MohdSiddique Bagwan <[email protected]>

metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py

@@ -132,9 +132,9 @@ def get_column_unique_count_patch(self: SqlAlchemyDataset, column: str) -> int:
         return convert_to_json_serializable(element_values.fetchone()[0])
     elif self.engine.dialect.name.lower() == "snowflake":
         element_values = self.engine.execute(
-            sa.select(
-                sa.func.APPROX_COUNT_DISTINCT(sa.column(column))
-            ).select_from(self._table)
+            sa.select(sa.func.APPROX_COUNT_DISTINCT(sa.column(column))).select_from(
+                self._table
+            )
         )
         return convert_to_json_serializable(element_values.fetchone()[0])
     return convert_to_json_serializable(

metadata-ingestion/src/datahub/ingestion/source/powerbi/m_query/parser.py

@@ -48,7 +48,7 @@ def get_upstream_tables(
     native_query_enabled: bool = True,
 ) -> List[resolver.DataPlatformTable]:
     if table.expression is None:
-        logger.debug(table.full_name, "Expression is none")
+        logger.debug("Expression is none for table %s", table.full_name)
         return []
 
     try:

metadata-ingestion/tests/integration/powerbi/test_m_parser.py

@@ -1,3 +1,5 @@
+import logging
+import sys
 from typing import List
 
 from lark import Tree
@@ -341,3 +343,27 @@ def test_table_combine():
         data_platform_tables[1].data_platform_pair.powerbi_data_platform_name
         == SupportedDataPlatform.SNOWFLAKE.value.powerbi_data_platform_name
     )
+
+
+def test_expression_is_none():
+    """
+    This test verifies the logging.debug should work if expression is None
+    :return:
+    """
+    # set logging to console
+    logging.getLogger().addHandler(logging.StreamHandler(sys.stdout))
+    logging.getLogger().setLevel(logging.DEBUG)
+
+    table: PowerBiAPI.Table = PowerBiAPI.Table(
+        expression=None,  # 1st index has the native query
+        name="virtual_order_table",
+        full_name="OrderDataSet.virtual_order_table",
+    )
+
+    reporter = PowerBiDashboardSourceReport()
+
+    data_platform_tables: List[DataPlatformTable] = parser.get_upstream_tables(
+        table, reporter
+    )
+
+    assert len(data_platform_tables) == 0