fix(ingestion): powerbi # Not all arguments converted to string #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
requested changes
Jan 27, 2023
| sa.select( | ||
| sa.func.APPROX_COUNT_DISTINCT(sa.column(column)) | ||
| ).select_from(self._table) | ||
| sa.select(sa.func.APPROX_COUNT_DISTINCT(sa.column(column))).select_from( |
There was a problem hiding this comment.
Why is there change in the formatting?
There was a problem hiding this comment.
lintFix is doing this
| @@ -48,7 +48,7 @@ def get_upstream_tables( | |||
| native_query_enabled: bool = True, | |||
| ) -> List[resolver.DataPlatformTable]: | |||
| if table.expression is None: | |||
| logger.debug(table.full_name, "Expression is none") | |||
| logger.debug("Expression is none for table %s", table.full_name) | |||
There was a problem hiding this comment.
Please, can you use fstring instead of format strings?
Something like this:
logger.debug(f"Expression is none for table {table.full_name}")
There was a problem hiding this comment.
I used above format because argument only get process if debug is enabled
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
…b-project#7157) Co-authored-by: MohdSiddique Bagwan <[email protected]>
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
…b-project#7157) Co-authored-by: MohdSiddique Bagwan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.