Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARQLConnector.update() does set content type #919

Closed
jpmccu opened this issue Jun 13, 2019 · 1 comment · Fixed by #1348
Closed

SPARQLConnector.update() does set content type #919

jpmccu opened this issue Jun 13, 2019 · 1 comment · Fixed by #1348

Comments

@jpmccu
Copy link
Contributor

jpmccu commented Jun 13, 2019

According to the spec, when posting text/plain data (which is what most web servers interpret a missing content-type as) to a SPARQL endpoint, you need to pass the update as a form-encoded dictionary. However, the current SPARQLConnector.update() function passes it as the data body, which would be fine if the content type were set to application/sparql-update. It's probably easier to set the content type correctly, but the current state will fail on SPARQL endpoints (like Blazegraph) that interpret this strictly.

@robcast
Copy link
Contributor

robcast commented Jan 8, 2021

Thanks for spotting this @jimmccusker! I just ran into the same problem with some obscure error messages when I tried to use RDFLib 5.0.0 with Blazegraph (worked fine with 4.2.2).

...looks like it's been fixed in da99d4e. Now if there would be a new release... :-)

jpmccu referenced this issue Jan 8, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andrewkroh Andrew Kroh
…header before sending the update query to a the SPARQL update endpoint
aucampia added a commit to aucampia/rdflib that referenced this issue Jun 27, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andrewkroh Andrew Kroh
aucampia added a commit to aucampia/rdflib that referenced this issue Jun 27, 2021
…and sparqlstore

Issue RDFLib#919 is already fixed, this just confirms it.
aucampia added a commit to aucampia/rdflib that referenced this issue Jul 7, 2021
…and sparqlstore

Issue RDFLib#919 is already fixed, this just confirms it.
nicholascar added a commit that referenced this issue Jul 12, 2021
Add unit test for #919 and more type hints for sparqlconnector and sparqlstore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants