Add unit test for #919 and more type hints for sparqlconnector and sparqlstore #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and sparqlstore Issue RDFLib#919 is already fixed, this just confirms it.
aucampia
force-pushed
the
iwana-issue919-tests
branch
from
2619fa5 to
d989182
Compare
|
If you want I can make a PR with only the additional unit tests. |
|
I think it should be fine. Adding type hints is a nice addition. I will look at this one after I finish reviewing #1074. |
edmondchuc
approved these changes
Jul 9, 2021
nicholascar
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #919 is already fixed by da99d4e, this just confirms it.
Closes #919
Proposed Changes