Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/lpc2387-based: Model features in Kconfig #14471

Merged

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This PR adds the features for all lpc2387-based boards. The symbols for the arm7tdmi_s core and the implemented armv4t architecture are also added. Missing CPU_ symbols are added to the Makefiles. The boards are:

  • avsextrem
  • mcb2388
  • msba2

Testing procedure

  • Check the symbol naming and organization
  • Green CI
  • test/kconfig_features should pass for all the boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jul 9, 2020
cpu/lpc2387/Kconfig Outdated Show resolved Hide resolved
@aabadie
Copy link
Contributor

aabadie commented Jul 16, 2020

#14539 is merged, please rebase and adapt accordingly :)

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/lpc2387_boards_symbols branch from 94bb46b to 775d9c1 Compare July 16, 2020 17:03
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/lpc2387_boards_symbols branch from 775d9c1 to cd4571b Compare July 16, 2020 17:08
@leandrolanzieri
Copy link
Contributor Author

Adapted and rebased. Also modified the commit messages accordingly

Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
@aabadie aabadie merged commit 4da79fa into RIOT-OS:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants