-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/lpc2387-based: Model features in Kconfig #14471
Merged
aabadie
merged 6 commits into
RIOT-OS:master
from
leandrolanzieri:pr/kconfig/lpc2387_boards_symbols
Jul 16, 2020
Merged
boards/lpc2387-based: Model features in Kconfig #14471
aabadie
merged 6 commits into
RIOT-OS:master
from
leandrolanzieri:pr/kconfig/lpc2387_boards_symbols
Jul 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Area: Kconfig
Area: Kconfig integration
labels
Jul 9, 2020
leandrolanzieri
requested review from
aabadie,
cgundogan,
jia200x,
maribu,
MichelRottleuthner and
smlng
as code owners
July 9, 2020 07:55
aabadie
reviewed
Jul 16, 2020
#14539 is merged, please rebase and adapt accordingly :) |
leandrolanzieri
force-pushed
the
pr/kconfig/lpc2387_boards_symbols
branch
from
July 16, 2020 17:03
94bb46b
to
775d9c1
Compare
HAS_ARCH_ARM features now is moved to Kconfig.features as it is being used by multiple architectures.
leandrolanzieri
force-pushed
the
pr/kconfig/lpc2387_boards_symbols
branch
from
July 16, 2020 17:08
775d9c1
to
cd4571b
Compare
Adapted and rebased. Also modified the commit messages accordingly |
aabadie
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. ACK
aabadie
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Kconfig
Area: Kconfig integration
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds the features for all
lpc2387
-based boards. The symbols for the arm7tdmi_s core and the implemented armv4t architecture are also added. MissingCPU_
symbols are added to the Makefiles. The boards are:avsextrem
mcb2388
msba2
Testing procedure
test/kconfig_features
should pass for all the boardsIssues/PRs references
Part of #14148