Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/lpc2387: rename to lpc23xx #14539

Merged
merged 6 commits into from
Jul 16, 2020
Merged

cpu/lpc2387: rename to lpc23xx #14539

merged 6 commits into from
Jul 16, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 16, 2020

Contribution description

As proposed in #14471 (comment), this PR renames the lpc2387 cpu to lpc23xx since it's used for lpc2387 and lpc2388 cpu models.

Testing procedure

  • A green Murdock
  • Run some functional tests on the affected boards: msba2, mcb2388 and avsextrem

Issues/PRs references

Required for #14471

@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Jul 16, 2020
@aabadie aabadie requested review from benpicco and maribu July 16, 2020 14:32
benpicco
benpicco approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Murdock is happy, this should be good
The other MCUs from this family (e.g. lpc2368) are very alike and should be easy to support if someone fancies retro-computing. 😄

@aabadie aabadie force-pushed the pr/cpu/lpc2387_rename branch from 308738f to 0a699e8 Compare July 16, 2020 15:01
@aabadie
Copy link
Contributor Author

aabadie commented Jul 16, 2020

There were some remaining occurrences of lpc2387 that needed to be changed. I amended the changes directly.

@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
@aabadie
Copy link
Contributor Author

aabadie commented Jul 16, 2020

Murdock is green, I'm merging this one. Thanks for reviewing @benpicco ;)

@aabadie aabadie merged commit d0fb8d7 into RIOT-OS:master Jul 16, 2020
@aabadie aabadie deleted the pr/cpu/lpc2387_rename branch July 16, 2020 16:38
@aabadie aabadie mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@maribu maribu Awaiting requested review from maribu maribu is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@roberthartung roberthartung Awaiting requested review from roberthartung

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @benpicco @leandrolanzieri