saml1x: Remove MPU feature #14806
Merged
saml1x: Remove MPU feature #14806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
added
Type: bug
benpicco
approved these changes
Aug 20, 2020
The MPU on the cortex-m23 has some differences with the MPU on the older cortex-m devices. It is not implemented in the cortex-m MPU driver. This removes the available feature as it gives a false sense of security by advertising the feature, but implementing it with noop's
bergzand
force-pushed
the
pr/saml1x/disable_mpu_feature
branch
from
139a18b to
6fa2b44
Compare
bergzand
requested review from
cgundogan,
jia200x and
leandrolanzieri
as code owners
|
I've amended the commit to also remove the feature from the Kconfig file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The MPU on the cortex-m23 has some differences with the MPU on the older
cortex-m devices. It is not implemented in the cortex-m MPU driver. This
removes the available feature as it gives a false sense of security by
advertising the feature, but implementing it with noop's
Testing procedure
applications on the saml1x should no longer crash :)
Issues/PRs references
see #14355