Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/stm32: disable MPU for cortex-m0+ (stm32g0 and stm32l052t8) #14823

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Aug 21, 2020

Contribution description

This PR remove the MPU feature from the list of features provided by the stm32g0 family and stm32l052t8 model since MPU is broken on cortex-m0+ and this results in nearly usable state for stm32g0 family and the related stm32l0 model.

Testing procedure

All applications are now working on nucleo-g070rb and i-nucleo-lrwan1

Issues/PRs references

This was reported in #14822 (Let's keep it open until a real fix is proposed and the feature can be re-enabled)

MPU is broken on cortex-m0+ in the current state
@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 21, 2020
@aabadie aabadie requested a review from bergzand August 21, 2020 12:58
@aabadie aabadie force-pushed the pr/cpu/stm32g0_disable_mpu branch from cf805e0 to fd71e09 Compare August 21, 2020 12:59
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, similar to #14806

@bergzand
Copy link
Member

bergzand commented Aug 21, 2020

fixes #14822

@aabadie
Copy link
Contributor Author

aabadie commented Aug 21, 2020

fixes #14822

can we keep it open until this is really fixed ?

@bergzand
Copy link
Member

can we keep it open until this is really fixed ?

Only if you change it to "MPU doesn't work on Cortex-m0+" :)

@aabadie
Copy link
Contributor Author

aabadie commented Aug 21, 2020

Only if you change it to "MPU doesn't work on Cortex-m0+" :)

Done

@benpicco
Copy link
Contributor

Only if you change it to "MPU doesn't work on Cortex-m0+" :)

We have a lot more Cortex-m0+ than sam32g0 - should we disable the MPU there too?

@bergzand
Copy link
Member

We have a lot more Cortex-m0+ than stm32g0 - should we disable the MPU there too?

I think so yes, they are probably as broken as the stm32g0

@aabadie
Copy link
Contributor Author

aabadie commented Aug 21, 2020

There's only one stm32l0 cpu model left for cortex-m0+. There's also saml1x but it's cortex-m23 and I don't know the state for those ones.
I can extend this PR for the stm32l0, if you want.

@bergzand
Copy link
Member

I can extend this PR for the stm32l0, if you want.

Fine with me!

Only stm32l0 cpu model for cortex-m0+. There's also saml1x but it's cortex-m23 and I don't know the state for those ones.

The saml1x is already disabled with #14806. (and yeah, cortex-m23 is also broken.)

@aabadie
Copy link
Contributor Author

aabadie commented Aug 21, 2020

I tried i-nucleo-lrwan1 (the stm32l0) and it's broken the same.

@aabadie aabadie changed the title cpu/stm32: disable MPU for stm32g0 cpu/stm32: disable MPU for cortex-m0+ (stm32g0 and stm32l052t8) Aug 21, 2020
@aabadie
Copy link
Contributor Author

aabadie commented Aug 21, 2020

Wait, this time I forgot to update Kconfig ;)

@aabadie aabadie force-pushed the pr/cpu/stm32g0_disable_mpu branch from ea152cc to b4aa2da Compare August 21, 2020 13:25
@aabadie aabadie merged commit bb62b24 into RIOT-OS:master Aug 21, 2020
@aabadie aabadie deleted the pr/cpu/stm32g0_disable_mpu branch August 21, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants