vera++: increase line length

[aabadie]

Contribution description

The vera++ warning annotation about the 80 character max line length is cluttering the review process on certain files.

This PR is increasing the warning line length to 100 and max line length to 120.

Testing procedure

The bogus commit should report annotations about maximum line length.

Issues/PRs references

Should improve the situation in PR like #15718 (see https://github.com/RIOT-OS/RIOT/pull/15718/files#diff-1e6a82d8739f75dd4cddea9ecc25505ed042f3670ee5646dfc0c97dba2881662)

[aabadie]

The new values are correctly taken into account. Next question: do these values make sense ?

[miri64]

If the coding conventions are changed, this should be documented as well ;-).

[miri64]

This PR is increasing the warning line length to 100 and max line length to 120.

Are we really needing 120 here? Why not just set he maximum line length to 100, period?

[bergzand]

I'm also for a single max. Having a warning line would trigger warning messages from Vera++ on every PR that changes a file with lines over the warning limit, even if the changes are not related to the lines causing the warning (right?)

[miri64]

This also would make a mod of the coding conventions unnecessary. The optional 80 char max could still be upheld manually.

[aabadie]

If the coding conventions are changed, this should be documented as well

I pushed b5c7d9d to adapt the values in the coding conventions.

[aabadie]

Hmm, sorry I misunderstood the comments above. So we agree on a single value of 100 characters per line ?

[miri64]

Hmm, sorry I misunderstood the comments above. So we agree on a single value of 100 characters per line ?

As the absolute maximum, yes. I think however we can keep the 80 char limit as someone an individual developer can look out for or configure their IDE to ;-).

[miri64]

ACK from my side. @jia200x if you like to comment, do it soon ;-).

[jia200x]

I'm fine with it!

[maribu]

ACK

[miri64]

@aabadie please remove the REMOVE ME commit :-).

[aabadie]

Another side effect of this PR will be to limit the output of the vera++ check when run on master.

[miri64]

Another side effect of this PR will be to limit the output of the vera++ check when run on master.

I actually thought that was your main motivation 😀

[aabadie]

I actually thought that was your main motivation

Let's say it was not the only one :)

[miri64]

Mhh for some reason the 80 chars warning still shows up.

[jia200x]

Mhh for some reason the 80 chars warning still shows up.

see #15813