ci/vera++/rules/L004: remove warning support #15813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia200x
requested review from
cgundogan,
haukepetersen and
PeterKietzmann
as code owners
|
I know it is a revert commit, but still I would prefer it to have a proper commit summary (the message can still contain "This reverts commit f3a934a." for posterity). Maybe something like: ? |
miri64
changed the title
This reverts commit f3a934a.
|
done :) |
jia200x
force-pushed
the
pr/vera/revert_tcl
branch
from
1e29b19 to
bcc9df6
Compare
jia200x
added
CI: skip compile test
|
Please remove the REMOVE ME commit. |
|
done :) |
jia200x
force-pushed
the
pr/vera/revert_tcl
branch
from
bcc9df6 to
d5062cf
Compare
miri64
added
Area: tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This reverts commit f3a934a.
The original patch added a mechanism to avoid 2 consecutive calls to
vera++, assuming we would be using both warnings and errors for line length.Since #15793 removed the warning, this patch is required to go back to the vanilla use case of vera++ (only report, no prints).
This should fix the issue described in #15793 (comment)
Testing procedure
Check
vera++output with the bogus commit.Issues/PRs references
#15793