Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/samd21-xpro: configure serial flash #17692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

boards/samd21-xpro: configure serial flash #17692

wants to merge 1 commit into from
+76 −0

Conversation

benpicco
Copy link
Contributor

Contribution description

The SAM D21 Xplained Pro comes with a 1 MiB AT25DF081A serial flash.

Testing procedure

Run tests/mtd_raw

mtd devices: 1
 -=[ MTD_0 ]=-
sectors: 256
pages per sector: 16
page size: 256
total: 1 MiB

Unfortunately the flash on my board ignores all writes, some unlock command might be needed.

Issues/PRs references

@benpicco benpicco requested a review from dylad as a code owner February 23, 2022 17:16
@github-actions github-actions bot added Area: boards Area: Board ports Area: drivers Area: Device drivers labels Feb 23, 2022
@benpicco benpicco force-pushed the boards/samd21-xpro-mtd branch from acb9760 to 8671997 Compare February 23, 2022 17:18
@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Feb 23, 2022
@dylad dylad added this to the Release 2022.04 milestone Feb 23, 2022
@dylad
Copy link
Member

dylad commented Feb 23, 2022

Changes looks good to me. I checked the pins connection and the flash datasheet.
Unfortunately, I don't own this one, and the few available on iotlab are somehow broken.
Maybe @aabadie or @fjmolinas could give it a quick test if they have access to one ?

@fjmolinas
Copy link
Contributor

Unfortunately the flash on my board ignores all writes, some unlock command might be needed.

So you are able to read but not write? Is there some insight into how to unlock this?

@benpicco
Copy link
Contributor Author

So you are able to read but not write?

exactly

Is there some insight into how to unlock this?

I did not yet look into this any further

@benpicco benpicco force-pushed the boards/samd21-xpro-mtd branch from 8671997 to 37df78e Compare February 25, 2022 14:02
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: tools Area: Supplementary tools labels Feb 25, 2022
@benpicco benpicco force-pushed the boards/samd21-xpro-mtd branch from 37df78e to 1d720d1 Compare February 26, 2022 22:24
@benpicco benpicco mentioned this pull request Mar 27, 2022
Merged
@benpicco
boards/samd21-xpro: configure serial flash
6ce674a 
The SAM D21 Xplained Pro comes with a 1 MiB AT25DF081A serial flash.
@benpicco benpicco force-pushed the boards/samd21-xpro-mtd branch from 1d720d1 to 6ce674a Compare April 12, 2022 13:17
@github-actions github-actions bot removed the Area: drivers Area: Device drivers label Apr 12, 2022
@benpicco benpicco removed this from the Release 2022.04 milestone Apr 29, 2022
@benpicco benpicco mentioned this pull request Aug 21, 2022
Merged
@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Nov 2, 2022
@benpicco
Copy link
Contributor Author

This is btw the same chip/issue as on the samr34-xpro

@dylad dylad added State: don't stale State: Tell state-bot to ignore this issue and removed State: stale State: The issue / PR has no activity for >185 days labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas left review comments

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines State: don't stale State: Tell state-bot to ignore this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @dylad @fjmolinas