boards/samr34-xpro: configure SPI NOR flash #18492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
reviewed
Aug 21, 2022
benpicco
force-pushed
the
boards/samr34-xpro_nor
branch
2 times, most recently
from
0372a87 to
ca2db50
Compare
benpicco
changed the title
maribu
reviewed
Aug 21, 2022
benpicco
force-pushed
the
boards/samr34-xpro_nor
branch
2 times, most recently
from
d9cf4f9 to
5678762
Compare
benpicco
added
the
CI: ready for build
maribu
approved these changes
Aug 26, 2022
|
Looks like DMA is not supported with SERCOM5. It is interesting that there still is a |
benpicco
force-pushed
the
boards/samr34-xpro_nor
branch
from
5678762 to
8fc1400
Compare
benpicco
requested review from
leandrolanzieri and
MrKevinWeiss
as code owners
benpicco
force-pushed
the
boards/samr34-xpro_nor
branch
from
8fc1400 to
9912790
Compare
maribu
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
There was only SPI config for the internal SPI (wired to sx1276). Also add an external SPI bus wired to the EXT pin headers.
The WLR089 board also comes with a NOR flash soldered on that is connected to this bus, so also configure it.
(It's the same as on
samd21-xpro, see #17692)Testing procedure
Issues/PRs references