Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/cpp11-compat: add kconfig support and add Kconfig for cpp11 test applications #17992

Merged
merged 5 commits into from
Apr 25, 2022
Merged

sys/cpp11-compat: add kconfig support and add Kconfig for cpp11 test applications #17992

merged 5 commits into from
Apr 25, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 23, 2022 •
edited
Loading

Contribution description

This PR adds Kconfig support to cpp11-compat module and also add an app.config.test file to tests/cpp* applications.

Testing procedure

Green Murdock is enough (but hard to reach)

Issues/PRs references

Required by #17985

@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework labels Apr 23, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: C++ Area: C++ wrapper labels Apr 23, 2022
@aabadie aabadie mentioned this pull request Apr 23, 2022
Merged
@aabadie aabadie requested a review from kaspar030 as a code owner April 23, 2022 17:55
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Apr 23, 2022
@aabadie aabadie mentioned this pull request Apr 24, 2022
Merged
@aabadie aabadie force-pushed the pr/sys/cpp_kconfig branch 3 times, most recently from fbb73ac to 45fb4cd Compare April 24, 2022 13:56
@aabadie aabadie force-pushed the pr/sys/cpp_kconfig branch 2 times, most recently from 4ed8ac6 to 684cabf Compare April 24, 2022 19:25
@github-actions github-actions bot removed the Area: CI Area: Continuous Integration of RIOT components label Apr 24, 2022
@aabadie aabadie changed the title sys/cpp11-compat: add kconfig support and add Kconfig for cpp test applications sys/cpp11-compat: add kconfig support and add Kconfig for cpp11 test applications Apr 24, 2022
fjmolinas
fjmolinas approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas fjmolinas enabled auto-merge April 25, 2022 06:45
@fjmolinas fjmolinas merged commit c56e28a into RIOT-OS:master Apr 25, 2022
@aabadie aabadie deleted the pr/sys/cpp_kconfig branch April 25, 2022 07:48
@aabadie aabadie mentioned this pull request Apr 25, 2022
Merged
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: C++ Area: C++ wrapper Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @fjmolinas @chrysn