Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/{cpp_ext, cpp_exclude}: model in kconfig #17994

Merged
merged 2 commits into from
May 10, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 25, 2022

Contribution description

This PR slightly adapts the dependencies of tests/cpp_ext and tests/cpp_exclude test application (just remove apparently useless libstdcpp required feature) and add to them a Kconfig app.config.test file.

Testing procedure

Green Murdock should be enough

Issues/PRs references

I dropped that change from #17992 because I couldn't find why libstdcpp dependency resolution is different with and without TEST_KCONFIG set on esp32. And apparently libstdcpp is not needed in these applications.

@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework labels Apr 25, 2022
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 25, 2022
@aabadie aabadie force-pushed the pr/tests/cpp_kconfig branch from 23e38ca to a23d4ef Compare April 25, 2022 16:48
@aabadie aabadie force-pushed the pr/tests/cpp_kconfig branch from a23d4ef to 35643dc Compare May 6, 2022 09:53
@aabadie aabadie requested a review from MrKevinWeiss as a code owner May 6, 2022 09:53
@aabadie aabadie enabled auto-merge May 6, 2022 16:14
@aabadie
Copy link
Contributor Author

aabadie commented May 6, 2022

This one is finally green. Just missing an ACK

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward

@aabadie aabadie merged commit 7e13424 into RIOT-OS:master May 10, 2022
@aabadie aabadie deleted the pr/tests/cpp_kconfig branch May 10, 2022 07:31
@MrKevinWeiss
Copy link
Contributor

Hmm, the only thing I was unsure about was a module selecting HAS_* which is normally selected based on the arch, for example, the arduino-mega2560 does not have libstdcpp. It passes murdock because the supported boards check is done with make but when running with TEST_KCONFIG we get:

/home/weiss/wd/RIOT/tests/cpp_exclude/main.cpp:21:18: fatal error: cstdio: No such file or directory
compilation terminated.
make[1]: *** [/home/weiss/wd/RIOT/Makefile.base:166: /home/weiss/wd/RIOT/tests/cpp_exclude/bin/arduino-mega2560/application_tests_cpp_exclude/main.o] Error 1
make: *** [/home/weiss/wd/RIOT/tests/cpp_exclude/../../Makefile.include:744: application_tests_cpp_exclude.module] Error 2
make: Leaving directory '/home/weiss/wd/RIOT/tests/cpp_exclude'

@MrKevinWeiss
Copy link
Contributor

I just didn't have a better way to solve it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants