Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ztimer: deprecate ztimer_now64 and ztimer_now_t #18054

Merged
merged 1 commit into from
May 4, 2022
Merged

ztimer: deprecate ztimer_now64 and ztimer_now_t #18054

merged 1 commit into from
May 4, 2022

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented May 4, 2022 •
edited
Loading

Contribution description

This deprecates ztimer_now64-module and ztimer_now_t in favour of ztimer64-module ztimer64_now() if 64Bit are need or
uint32_t the return type of ztimer_now()

Testing procedure

read doc and murdock green

Issues/PRs references

@kfessel kfessel requested review from kaspar030 and bergzand as code owners May 4, 2022 14:04
@github-actions github-actions bot added Area: build system Area: Build system Area: sys Area: System Area: timers Area: timer subsystems labels May 4, 2022
@kfessel kfessel requested a review from fjmolinas May 4, 2022 14:05
kaspar030
kaspar030 approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kfessel kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 4, 2022
@kfessel kfessel mentioned this pull request May 4, 2022
Closed
@chrysn chrysn enabled auto-merge May 4, 2022 14:52
@fjmolinas fjmolinas added the Process: deprecation Integration Process: The PR is deprecating a feature or API label May 4, 2022
@chrysn chrysn merged commit 1259fb6 into RIOT-OS:master May 4, 2022
@kfessel
Copy link
Contributor Author

kfessel commented May 5, 2022

is it possible to add the Pseudo module to the Documentation deprecation list? see https://output.circle-artifacts.com/output/job/45a285d1-ccad-4bb0-a9b6-1959b0ff9dbb/artifacts/0/doc/deprecated.html

@miri64
Copy link
Member

miri64 commented May 9, 2022

Just add a doxygen group for that module and add the @deprecated tag to it.

@kfessel
Copy link
Contributor Author

kfessel commented May 9, 2022

Just add a doxygen group for that module and add the @deprecated tag to it.

Is there a good location for this -ztimer.h seems to be the wrong place.

@miri64
Copy link
Member

miri64 commented May 9, 2022

Is there a good location for this -ztimer.h seems to be the wrong place.

If there is no more fitting place, put it there. Otherwise, there is always doc.txt... but to me, a header file seems more fitting.

@kfessel kfessel mentioned this pull request May 13, 2022
Merged
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: sys Area: System Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: deprecation Integration Process: The PR is deprecating a feature or API
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
5 participants
@kfessel @miri64 @kaspar030 @chrysn @fjmolinas