Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztimer: add module removal information to doxygen and date it #18105

Merged
merged 1 commit into from
May 25, 2022

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented May 13, 2022

Contribution description

i missed the module in #18054

Testing procedure

Read the build artefact

Issues/PRs references

#18054

@kfessel kfessel requested a review from miri64 May 13, 2022 18:07
@github-actions github-actions bot added Area: sys Area: System Area: timers Area: timer subsystems labels May 13, 2022
@kfessel kfessel force-pushed the p-deprecate-ztimer-now64-2 branch 4 times, most recently from 85762d6 to 3795d07 Compare May 13, 2022 18:31
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 13, 2022
miri64
miri64 previously requested changes May 14, 2022
@miri64 miri64 added Process: deprecation Integration Process: The PR is deprecating a feature or API Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: doc Area: Documentation labels May 14, 2022
@github-actions github-actions bot removed the Area: doc Area: Documentation label May 14, 2022
@kfessel kfessel force-pushed the p-deprecate-ztimer-now64-2 branch from b085ee5 to a86c697 Compare May 14, 2022 18:39
@fjmolinas
Copy link
Contributor

LGTM, please squash! @miri64 have your change requests been addressed?

@kfessel kfessel force-pushed the p-deprecate-ztimer-now64-2 branch from a86c697 to b7fef93 Compare May 19, 2022 09:39
* Will be removed after 2022.10 release.
*/
/**
* @typedef ztimer_now_t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be needed, but not blocking for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is easier to read this way (i think you suggest the @typedef ... might not be needed)

@miri64 miri64 dismissed their stale review May 23, 2022 09:13

Yes, my change requests were addressed.

@kfessel kfessel requested a review from fjmolinas May 25, 2022 15:43
@kfessel
Copy link
Contributor Author

kfessel commented May 25, 2022

missing an approval

@miri64 miri64 enabled auto-merge May 25, 2022 16:53
@miri64 miri64 merged commit 2d67eaf into RIOT-OS:master May 25, 2022
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: deprecation Integration Process: The PR is deprecating a feature or API Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants