cpu/esp32: add ESP32-C3 support in makefiles #18341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: cpu
gschorcht
added
Type: new feature
benpicco
approved these changes
Jul 20, 2022
I have splitted all changes that can be merged independently on the core PR for ESP32-C3 support. Most of them don't ned full CI compilation yet.
Yes, but these are more changes 39905cb that should be probably part of the core PR for ESP32-C3 to be covered by CI compilation. If you think that it makes sense to split it off to decrease the size of core PR further, I could do it. The remaining core PR size is 40 files changed, 2406 insertions(+), 3 deletions(-). |
gschorcht
force-pushed
the
cpu/esp32/add_esp32c3_makefile_support
branch
from
c263d47 to
0645371
Compare
|
That's much better, thank you! |
|
@benpicco Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17844, which adds the support of ESP32-C3 in makefiles.
Testing procedure
It is not yet possible to cover this PR when compiling in CI without having ESP32-C3 support and a board definition with an ESP32-C3. Vice versa, the ESP32-C3 port that needs this PR cannot be compiled in CI without it.
Therefore a green CI with the label
CI: skip compile testmust be sufficient for the moment. If it doesn't work, the problem will pop up as soon as ESP32-C3 support is provided. And of course, I have tested it together with the ESP32-C3 support in PR #17844.Issues/PRs references
Split-off from PR #17844