makefiles/arch/riscv.inc.mk: Clean up target triple detection #19062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riscv-none-embed is a technically incorrect target triple that was used in a previously popular legacy toolchain. It is not possible anymore to create a toolchain with that triple from upstream sources and all popular distros have migrated. It should be safe to ditch that now.
maribu
added
Type: cleanup
github-actions
bot
added
Area: build system
benpicco
approved these changes
Dec 16, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Dec 16, 2022
19062: makefiles/arch/riscv.inc.mk: Clean up target triple detection r=maribu a=maribu ### Contribution description `riscv-none-embed` is a technically incorrect target triple that was used in a previously popular legacy toolchain. It is not possible anymore to create a toolchain with that triple from upstream sources and all popular distros have migrated. It should be safe to ditch that now. ### Testing procedure Since we were basically waiting for the CI to also ditch that legacy toolchain, a green Murdock will be the important part. In addition, it would be nice to check if building RISC-V binaries still works with the toolchain Ubuntu ships. ### Issues/PRs references None Co-authored-by: Marian Buschsieweke <[email protected]>
|
Build failed: |
|
This looks bad... |
|
bors merge |
|
Hmm, IIUC this PR relies on the changes that were reverted to fix the CI. Cancelling bors for now. bors merge- |
|
Canceled. |
maribu
added
the
State: waiting for CI update
Yes, exactly. I added a label to indicate the state. Looks like this is something to tackle after the next release. |
⏰ |
|
Sadly, the RISC-V toolchain in the CI is still the unmaintained Maybe @benpicco wants to give switching the RISC-V toolchain to something modern another try? |
|
Superseded by: #20380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
riscv-none-embedis a technically incorrect target triple that was used in a previously popular legacy toolchain. It is not possible anymore to create a toolchain with that triple from upstream sources and all popular distros have migrated. It should be safe to ditch that now.Testing procedure
Since we were basically waiting for the CI to also ditch that legacy toolchain, a green Murdock will be the important part. In addition, it would be nice to check if building RISC-V binaries still works with the toolchain Ubuntu ships.
Issues/PRs references
None