Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree wide: accommodate RISC-V toolchain update #20380

Merged
merged 4 commits into from
Feb 13, 2024
Merged

tree wide: accommodate RISC-V toolchain update #20380

merged 4 commits into from
Feb 13, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Feb 12, 2024 •
edited
Loading

Contribution description

This contains fixed needed after updating the RISC-V toolchain in the CI

Testing procedure

Build riotbuild from RIOT-OS/riotdocker#248 locally, then run

env DOCKER_IMAGE=<LOCAL_BUILD_ID> ./dist/tools/insufficient_memory/update_insufficient_memory_board.sh hifive1b

This should fail for each and every build in master, but work for each and every build with this PR

Issues/PRs references

Depends on:

@maribu
makefiles/arch/riscv.inc.mk: update RISC-V target triple
d59977c 
The CI now uses `riscv-none-elf` over the previous (and technically
incorrect) `riscv-none-embed`. In addition, we no longer probe for
host toolchains with the incorrect target triple, as the source
providing it has long declared the toolchain with the incorrect
triple as obsolete.
@maribu
dist/tools/ci/print_toolchain_versions.sh: Update
1479454 
This drops support for the legacy riscv-none-embed target triple. That
value has been incorrect since the beginning and the toolchain that
used that has been long declared obsolete and is fairly outdated.

With our CI updating the toolchain, we no longer need to check for
that.
@maribu
markfiles/cargo-targets.inc.mk: Drop legacy triple
663b74c 
The legacy `riscv-none-embed` target triple is incorrect and the
toolchain using it has long been obsolete. With our CI no longer
using the obsolete toolchain, there is no need to handle that one
anymore.
@maribu
examples,tests: update Makefile.ci
dd0de1b 
With the new RISC-V toolchain, some binaries grew larger, most smaller.
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: build system Area: Build system Area: tools Area: Supplementary tools Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: examples Area: Example Applications labels Feb 12, 2024
@maribu maribu mentioned this pull request Feb 12, 2024
Merged
kaspar030
kaspar030 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Feb 13, 2024
@maribu maribu enabled auto-merge February 13, 2024 10:12
@maribu maribu disabled auto-merge February 13, 2024 10:14
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 13, 2024
@kaspar030 kaspar030 enabled auto-merge February 13, 2024 10:47
@riot-ci
Copy link

riot-ci commented Feb 13, 2024 •
edited
Loading

Murdock results

✔️ PASSED

dd0de1b examples,tests: update Makefile.ci

Success Failures Total Runtime
10008 0 10010 13m:24s

Artifacts

@kaspar030 kaspar030 added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@maribu maribu added this pull request to the merge queue Feb 13, 2024
@maribu maribu mentioned this pull request Feb 13, 2024
Merged
2 tasks
Merged via the queue into RIOT-OS:master with commit 64a8f31 Feb 13, 2024
28 checks passed
@maribu maribu deleted the build-system/risc-v-toolchain-update branch February 13, 2024 15:21
@maribu maribu mentioned this pull request Feb 19, 2024
Closed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@maribu maribu changed the title tree wide: accomodate RISC-V toolchain update tree wide: accommodate RISC-V toolchain update Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: examples Area: Example Applications Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @kaspar030 @MrKevinWeiss