Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/wakaama: Notify resource updates when writing to resources #20326

Merged

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

Currently one can update LwM2M resources using the functionalities in common.h. But this doesn't automatically marks them as changed for the LwM2M client to check if an observe notification may be required.

This PR proposes to include marking the resource as changed upon write, thus giving the possibility to generate observation notifications.

I had to include a path to the package to mark the uriP argument as const. Additionally fixed the numbering of the patches files in the package (because apparently I can't count).

Testing procedure

Issues/PRs references

You may want to take a look at #16204

@github-actions github-actions bot added the Area: pkg Area: External package ports label Feb 1, 2024
@leandrolanzieri leandrolanzieri added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Feb 1, 2024
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 1, 2024
@riot-ci
Copy link

riot-ci commented Feb 1, 2024

Murdock results

✔️ PASSED

d523d5d pkg/wakaama/common: mark resource as updated when written to

Success Failures Total Runtime
8627 0 8627 09m:05s

Artifacts

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward.

Have we ever tried getting those patches upstream?
We are using a version of the package that's 6 years old.

@benpicco benpicco added this pull request to the merge queue Feb 13, 2024
Merged via the queue into RIOT-OS:master with commit ee624b5 Feb 14, 2024
29 checks passed
@leandrolanzieri leandrolanzieri deleted the pr/pkg/wakaama_notify_resource_update branch February 14, 2024 06:37
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing :)

Have we ever tried getting those patches upstream?
We are using a version of the package that's 6 years old.

Not really, but I agree that's something towards which we should tend. I'll see if I can bump it and check what's still necessary.

@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@leandrolanzieri
Copy link
Contributor Author

BTW #20930 finally bumps this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants