-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wakaama update on new version #20930
Conversation
Hey @moritzholzer, thanks for working on this! For an easier reviewing process, I'd suggest you try to squash unnecessary commits (e.g., the merges). Please, make sure you check our commit conventions https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions Regarding the version bump, do you know whether there are plans from Wakaama on releasing a version 2.0? With this update, which is the highest LwM2M version that is supported? |
I wil squash the commits later. The lwm2m version is 1.0, some features 1.1. From what i can get from the issues in the wakaama repo there is not a fixed plan for a new version but it was discussed in the past without an conclusion. |
daf550d
to
0af25ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a first round of comments
I'v worked through the comments. |
I tested it on native and works well |
There seems to be a problem with a |
You may want to remove the |
Looks good. There's only one style comment pending. Please squash directly, so that we keep only meaningful commits in the history. |
2aa1f8d
to
863f0f6
Compare
863f0f6
to
abed01c
Compare
Is it enought squashed or are less commits better? |
Thanks @moritzholzer. I think there are some mix ups on the commit history. I see, for example, various changes of the pkg version? (ec5d90f and e0fe270) I would suggest having the following commits:
Also please check the messages. They should always start with the area of changes (e.g., |
abed01c
to
0829293
Compare
Thank you @leandrolanzieri for the help:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@moritzholzer there are some whitespace errors (see https://github.com/RIOT-OS/RIOT/actions/runs/11609350032/job/32530338557?pr=20930) |
0829293
to
97acd2e
Compare
I removed the whitespaces. |
Before the merge queue triggers a timeout, I'll drop and requeue this one. |
Contribution description
This patch updates the wakaama library to a new version (Commit ee0c98da7495e1ab43358b49e970dbc97f73ce3b).
It updates the RIOT code to the new interfaces.
Testing procedure
Test with the lwm2m example, with leshan demo server.