pkg/wakaama: Fix usages of lwm2m_uri_t and ISPO sensor
#21034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
Type: bug
leandrolanzieri
changed the title
lwm2m_uri_tlwm2m_uri_t and ISPO sensor
benpicco
added
the
CI: ready for build
leandrolanzieri
force-pushed
the
pr/wakaama/fix_uri
branch
from
981a07c to
f425df4
Compare
leandrolanzieri
force-pushed
the
pr/wakaama/fix_uri
branch
from
f425df4 to
52f1caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
#20930 updated the Wakaama package version. This version had some breaking changes. It seems that a change in
lwm2m_uri_tslipped through. This fixes its usages throughout the contrib code.EDIT:
I added a fix for a typo introduced in ISPO sensor base.
Testing procedure
The best test would be an example that uses some of the IPSO objects, because there the URIs are manipulated. But there's currently no example with them. You can check the upstream type definitions:
https://github.com/eclipse-wakaama/wakaama/blob/d28bd1411413e7978269dcdb538f0cee3d3c82ec/include/liblwm2m.h#L329-L348
Issues/PRs references
#20930