Update to Ubuntu Bionic #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some test results. Unfortunately, it is taking my (old) computer a very long time to compile, so it will be a few days before it has finished everything. |
|
Partial classification of failures. They all seem to be in relation to arm-non-eabi. |
|
It looks like the PPA has been discontinued: https://launchpad.net/gcc-arm-embedded It directs users to the ARM website. Also, it seems that arm-none-eabi from the Ubuntu repository has compatibility issues. I have updated the Dockerfile to download the file from the ARM website (which, oddly, redirects to windows.net). I have built to 15/28 in examples, and haven't hit any errors yet. I will post some output once I have more. |
|
What is the output of the toolchain versions script with this image? Edit: RIOT/dist/tools/ci/print_toolchain_versions.sh |
|
|
Current progress: everything in examples has been built, and tests is on 44/216. There has only been one error so far: tests/conn_can on hifive1 It is weird that only this toolchain returned that error. Even weirder is that if ret is initialized to 0, the following error occurs: |
|
Up to 171/216. Hit errors on the following: |
|
All test builds have completed with no further errors. |
aabadie
reviewed
Jul 5, 2018
Dockerfile
Outdated
| @@ -100,6 +92,13 @@ RUN wget -q https://cmake.org/files/v3.10/cmake-3.10.0.tar.gz -O- \ | |||
| | tar -C /tmp -xz && cd /tmp/cmake-3.10.0/ && ./bootstrap && \ | |||
| make && make install && cd && rm -rf /tmp/cmake-3.10.0 | |||
|
|
|||
| # Install ARM binary toolchain | |||
| RUN mkdir -p /opt && \ | |||
| wget -q https://armkeil.blob.core.windows.net/developer/Files/downloads/gnu-rm/7-2018q2/gcc-arm-none-eabi-7-2018-q2-update-linux.tar.bz2 -O- \ | |||
There was a problem hiding this comment.
You can use a more "official" base url: https://developer.arm.com/-/media/Files/downloads/gnu-rm/7-2018q2/gcc-arm-none-eabi-7-2018-q2-update-linux.tar.bz2.
For IoT-LAB, we use the following full command:
wget -nv -O - https://developer.arm.com/-/media/Files/downloads/gnu-rm/7-2018q2/gcc-arm-none-eabi-7-2018-q2-update-linux.tar.bz2 | tar -jxf -
With tar -C /opt -jxf -, it should be the same.
There was a problem hiding this comment.
So far, the URL used there is the one which redirects from the ARM website. Though both are the same and equally official.
|
There were a few false negatives in pkg_u8g2 (I think due to a thunderstorm temporarily interrupting Internet access). Here is the corrected list of failures: Here is the output from those builds: |
|
I have looked into those errors, and they all seem to be related to insufficient memory. I have created a PR to add them to The only odd one is hifive1, which got built for tests/conn_can despite already being listed in |
|
I have the same issue as you have for |
|
The linking issue with |
This was referenced Jul 27, 2018
|
All the necessary fixes have been applied to both master and the release branch. I will re-test the failed packages on the new image to confirm that everything is working. |
|
I have re-tested |
|
@gebart @kaspar030 is this then ready to merge? @ZetaR60 what about the msp430 errors? |
|
@kYc0o Everything has been fixed by RIOT-OS/RIOT#9507, RIOT-OS/RIOT#9627, RIOT-OS/RIOT#9643, and their respective backports. Apparently the msp430 errors were not unique to the new Docker image, so those systems needed to be added to |
cladmi
previously requested changes
Aug 2, 2018
There was a problem hiding this comment.
Not ready to merge because of context.
I would not merge this in a release testing time.
It would mean updating every containers now and maybe have users with different versions testing.
I would also like to know why there is this RIOT-OS/RIOT#9645 before changing the docker version.
|
@cladmi Is it necessary to wait on an issue that affects both Docker versions? I do want to make sure that this is done right, but I also have a PR RIOT-OS/RIOT#8842 that is waiting on the Docker update. |
6 tasks
cladmi
dismissed
their stale review
The main issue is fixed, there are still differences but can be adressed later
|
Thanks @cladmi Is this now ready to merge? |
|
Right now, nothing can be merged because of #46 Also I think some hack may not be needed anymore like |
|
At last! All applications have been built. There was another failure on |
This was referenced Oct 29, 2018
|
I currently have an issue with the bionic image when building from a worktree. I have a PR that address it RIOT-OS/RIOT#10303 . |
|
I managed to run the compile tests with this and got the same errors as the current image, and the However I am re-generating an image with it to verify it is working. |
cladmi
suggested changes
Nov 8, 2018
ZetaR60
force-pushed
the
riotdocker_bionic
branch
from
690627c to
c94218a
Compare
|
Rebased and squashed. Thanks for your testing and fixes @cladmi ! |
|
@smlng @kaspar030 do you see any other checks that should be done ? like for using it in murdock or something I missed |
jnohlgard
requested changes
Nov 20, 2018
There was a problem hiding this comment.
Please remove the hack download for Arch linux libfl.so (around line 130 in the updated Dockerfile)
@kaspar030 do you remember what tool was failing without the downloaded libfl.so? (It was added in #39 with the RISC-V toolchain download)
|
It was |
|
@ZetaR60 I see. |
|
Opened #62 for the RISC-V fix, as that is orthogonal to the Ubuntu upgrade |
In ubuntu bionic, `scan-build` has been moved to the `clang-tools`
package.
dpkg-query -S /usr/bin/scan-build
clang-tools: /usr/bin/scan-build
ZetaR60
force-pushed
the
riotdocker_bionic
branch
from
c94218a to
72c1dca
Compare
|
Rebased to pick up updates. @cladmi Are we ready to do final testing prior to merge? |
cladmi
approved these changes
Nov 27, 2018
|
I checked the rebased version was the same diff. |
|
Might be other issues coming later, but I think we prepared enough, so we will handle them when they happen. @ZetaR60 Thank you for following this one, was a hard one to track, test and go around unrelated issues. |
|
Now only need to be deployed on murdock. |
I've updated most murdock workers, just the kubernetes node from HAW are missing. I'm not administering them, @smlng? |
|
There is an issue open that would be useful for tracking the deployment: #9405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to Ubuntu Bionic, which is the most current LTS release.
The
team-gcc-arm-embeddedPPA is removed, as it does not support Bionic. The packagegcc-arm-embeddedwas from that PPA, but there is an equivalentgcc-arm-none-eabithat is probably newer anyway.I tested with
docker build -f Dockerfile ./and it builds successfully.Required for: RIOT-OS/RIOT#9405