-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apt: Use --no-install-recommends to avoid unnecessary extras #59
Conversation
I will run the buildtest during the release with this version. |
Thanks, @cladmi! |
I ran the compilation test with this, I will merge after the release. |
Only failed build was tests/gnrc_ipv6_nib but it also fails with the current image.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ACK but just wait for the release cycle to be finished for merging.
Thanks, @cladmi! |
@smlng @kaspar030 do you see any other checks that should be done ? like for using it in murdock or something I missed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. There were no objections said on this one.
Please rebase and merge when travis is happy.
b22f7c7
to
9d44f26
Compare
Rebased |
Add
--no-install-recommends
to apt-get commands to avoid pulling in optional dependencies which are not used by the build process.The image size reduction is approximately 430 MB
Testing
This needs a full buildtest run on the new image to ensure that no critical components are missing after adding this flag, but my laptop does not have the disk space or time to do it.