Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt: Use --no-install-recommends to avoid unnecessary extras #59

Merged
merged 2 commits into from
Nov 20, 2018

Conversation

jnohlgard
Copy link
Member

@jnohlgard jnohlgard commented Oct 21, 2018

Add --no-install-recommends to apt-get commands to avoid pulling in optional dependencies which are not used by the build process.

The image size reduction is approximately 430 MB

REPOSITORY                 TAG                 IMAGE ID            CREATED             SIZE
riot/riotbuild             norecommends        402547be3514        3 minutes ago       3.34 GB
riot/riotbuild             master              e4c568fc283a        44 minutes ago      3.77 GB

Testing

This needs a full buildtest run on the new image to ensure that no critical components are missing after adding this flag, but my laptop does not have the disk space or time to do it.

@cladmi
Copy link
Contributor

cladmi commented Oct 25, 2018

I will run the buildtest during the release with this version.

@jnohlgard
Copy link
Member Author

Thanks, @cladmi!

@cladmi
Copy link
Contributor

cladmi commented Nov 8, 2018

I ran the compilation test with this, scan-build in one example, and also the static-test.

I will merge after the release.

@cladmi
Copy link
Contributor

cladmi commented Nov 8, 2018

Only failed build was tests/gnrc_ipv6_nib but it also fails with the current image.

BOARD=waspmote-pro make -C tests/gnrc_ipv6_nib

RIOT-OS/Release-Specs#76 (comment)

Copy link
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ACK but just wait for the release cycle to be finished for merging.

@jnohlgard
Copy link
Member Author

Thanks, @cladmi!

@cladmi cladmi mentioned this pull request Nov 8, 2018
@cladmi
Copy link
Contributor

cladmi commented Nov 13, 2018

@smlng @kaspar030 do you see any other checks that should be done ? like for using it in murdock or something I missed

Copy link
Contributor

@cladmi cladmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. There were no objections said on this one.
Please rebase and merge when travis is happy.

@jnohlgard
Copy link
Member Author

Rebased

@jnohlgard jnohlgard merged commit d12a6e2 into RIOT-OS:master Nov 20, 2018
@jnohlgard jnohlgard deleted the pr/norecommends branch November 20, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants