Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tuned moe config for qwen1.5_moe_A2.7B #398

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

sky0530
Copy link

@sky0530 sky0530 commented Feb 3, 2025

This PR add tuned qwen1.5_moe_A2.7B moe config with tp = 1, batch = 1

@sky0530
Copy link
Author

sky0530 commented Feb 6, 2025

Add more batch size support.
This PR add tuned qwen1.5_moe_A2.7B moe config with tp = 1.
It's a small model. And it would not use multiple GPU to do inference

@divakar-amd
Copy link

Hi, thanks for the tuning configs. We would need a small update in the file names:

  • Can we remove the trailing "_OAM" from the names of these 4 json files? We want to keep the names consistent across all the mi300 machines. (PR for more details)

Also, it will be good to see some perf gains numbers obtained after the tuning as a measure of correct tuning process.

@sky0530
Copy link
Author

sky0530 commented Feb 9, 2025

With tuned moe config, the Qwen1.5_moe_A2.7B can improve E2E 3.5% performance
image

@sky0530
Copy link
Author

sky0530 commented Feb 9, 2025

@divakar-amd I have changed the filenames. Plz help to review the PR

@gshtras gshtras requested a review from divakar-amd February 10, 2025 15:36
Copy link

@divakar-amd divakar-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving!

@divakar-amd divakar-amd merged commit e2dc610 into ROCm:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants