Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key group #167

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Fix key group #167

merged 5 commits into from
Jun 10, 2020

Conversation

andremarcais
Copy link

Fixes/Closes #115

Description

  • Displays effective key group.
  • Re-displays on xkb state change.

Release notes

Notes: Bug fix for effective key group display.

@andremarcais
Copy link
Author

andremarcais commented Jun 3, 2020

As of now there is no mutex on the layout_text global (nor is there on any of the globals like unlock_state and modifier_string) which is potentially a problem for --redraw-thread.

@Raymo111
Copy link
Owner

Raymo111 commented Jun 8, 2020

@andremarcais what exactly is a key group? I just want to be certain before merging this.

@andremarcais
Copy link
Author

andremarcais commented Jun 10, 2020

In X, one of four key groups is active. X maps a keycode (which represents a physical key) and group to a character.

In higher level user configuration the user may, e.g., set the layout to us,fr, which causes Group 1 to be mapped to us characters and Group 2 to be mapped to fr characters. The active group determines what character results from a keycode.

Using options like grp:shifts_toggle makes switching the active group easy.

My explanation oversimplifies this a little bit. This page explains this in greater detail.

@Raymo111
Copy link
Owner

I see. Alright, I'll merge the PR.

Copy link
Owner

@Raymo111 Raymo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on working screencap and good feedback from other users.

@Raymo111 Raymo111 merged commit e30f18f into Raymo111:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update keyboard layout indicator on change
2 participants