Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --show-layout flag #141

Closed
wants to merge 1 commit into from
Closed

Add --show-layout flag #141

wants to merge 1 commit into from

Conversation

Valkyrihane
Copy link

@Valkyrihane Valkyrihane commented Oct 8, 2019

This flag displays the current keyboard layout next to the time.

Intends to close #107

Very small changes in order to display the keyboard layout on the lockscreen as cleanly as possible. The perfect way to do it would be to change the size of the rectangle on update(), but that is way too complex and unnecessary for an option like this in my opinion.

Another solution would be to use setxkbmap -query in order to always get two-letters code (us, fr, cn, ru, ...) and not i3lock's --keylayout option that displays (us, french, chinese, ...). Let me know what you think.

This flag displays the current keyboard layout next to the time.

Closes #107
@zachkont
Copy link

zachkont commented Jan 9, 2020

I think that i3lock's --keylayout option is not live, meaning that it will not update the label if the layout is changed while the screen is locked

@Rizhiy
Copy link
Contributor

Rizhiy commented Oct 28, 2020

I think that i3lock's --keylayout option is not live, meaning that it will not update the label if the layout is changed while the screen is locked

In https://github.com/Raymo111/i3lock-color it should be dynamic, see Raymo111/i3lock-color#167

@SebTM
Copy link
Collaborator

SebTM commented Jun 1, 2021

Thanks for your contribution, this will be resolved with the merge of the multi-monitor branch from multilockscreen-fork :)

@SebTM SebTM closed this Jun 1, 2021
@Valkyrihane
Copy link
Author

Valkyrihane commented Jun 1, 2021

Well, turns out I completely missed the PR approval notification 🤦‍♂️

Thanks for the heads-up @SebTM, I will thus delete my fork.
Cheers and keep up the good work! I am still using betterlockscreen daily

@SebTM
Copy link
Collaborator

SebTM commented Jun 2, 2021

No Problem, thanks for your support 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add current keyboard layout
5 participants