Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature to ignore repos #241

Merged

Conversation

adityajoshi12
Copy link
Contributor

@adityajoshi12 adityajoshi12 commented Jan 2, 2023

Signed-off-by: Aditya Joshi [email protected]

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

This PR contains the changeset for ignoring the events for repos defined in the configuration file. The repos that needs to be ignored can be defined as following In the configuration file.

settings:
  username: "Readme-Workflows"
  commit_msg: "⚡ Update README with the recent activity"
  max_lines: 5
  ...
  ignored_repos:
    - username/repo
   ...

Closes #223

@adityajoshi12 adityajoshi12 marked this pull request as ready for review January 2, 2023 06:54
@abhijoshi2k
Copy link
Member

abhijoshi2k commented Jan 4, 2023

Hi @adityajoshi12
The feature doesn't work on my repo. Please check again.
Workflow file
Config file

Try npm run build and then push.

Signed-off-by: Aditya Joshi <[email protected]>
@adityajoshi12
Copy link
Contributor Author

Hi @adityajoshi12 The feature doesn't work on my repo. Please check again. Workflow file Config file

Try npm run build and then push.
added the updated dist/index.js

@abhijoshi2k
Copy link
Member

It is working now.
@adityajoshi12 is this ready to merge?

@adityajoshi12
Copy link
Contributor Author

It is working now.
@adityajoshi12 is this ready to merge?

Sure, please go ahead.

@abhijoshi2k abhijoshi2k added the Status: Ready The Pull request is ready for reviews and getting merged label Jan 4, 2023
@abhijoshi2k abhijoshi2k merged commit 31d1547 into Readme-Workflows:main Jan 4, 2023
@abhijoshi2k abhijoshi2k mentioned this pull request Jan 4, 2023
3 tasks
@abhijoshi2k abhijoshi2k added the Type: enhancement New feature or request label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Ignoring repos
2 participants