Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Line Prefix #242

Merged
merged 14 commits into from
Jan 4, 2023
Merged

Feature/Line Prefix #242

merged 14 commits into from
Jan 4, 2023

Conversation

abhijoshi2k
Copy link
Member

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.

Description

This PR adds the functionality to control prefixes for each line like serial numbers.

settings:
  username: "Readme-Workflows"
  commit_msg: "⚡ Update README with the recent activity"
  max_lines: 5
  ...
  line_prefix: "{NUM}. "
   ...

Placeholder added:
{NUM} : Will be replaced by the serial number for the line.

Default value: "{NUM}. "

Closes #220

@abhijoshi2k abhijoshi2k added Type: enhancement New feature or request minor Will be added to next minor release Status: In progress This pr or issue is in progress Priority: low Low priority for this issue/pr. labels Jan 4, 2023
@abhijoshi2k abhijoshi2k marked this pull request as ready for review January 4, 2023 13:25
@abhijoshi2k abhijoshi2k merged commit dc1ccee into main Jan 4, 2023
@abhijoshi2k abhijoshi2k deleted the feature/serial-numbers branch January 4, 2023 13:33
@abhijoshi2k
Copy link
Member Author

@Andre601
Please update readme and changelog with respect to #242 and #241
Kindly release v2.4.1 after updation.
Thanks!

@abhijoshi2k abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels Jan 13, 2023
@readme-workflows
Copy link

The Pull request of @abhijoshi2k has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

This is an automated response created by a GitHub Action
Mentioning the Bot won't have any effect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetGopinath PuneetGopinath Awaiting requested review from PuneetGopinath PuneetGopinath is a code owner

Assignees
No one assigned
Labels
minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Option for toggling numbers
2 participants
@abhijoshi2k @abhijoshi2k-2