Locale supported as timezone #54

abhijoshi2k · 2021-05-22T12:22:12Z

Checks

I have...

read and understood the Contributing Guidelines
Updated README.md.
Updated CHANGELOG.md.

Type of Pull request

Minor Change
This Pull request doesn't break existing configuration.
Major Change
This Pull request will break existing configuration.
Bug fix
This Pull request will fix a (critical) bug.
Documentation
This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)

Description

Timezone support extended. It can now accept locale string as "continent/city"
f.e. GMT+0530 or Asia/Kolkata
Formats for all timezones can be viewed here : https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

🔴🔴 Breaking Change 🔴🔴

TIMEZONE_OFFSET input has now changed to TIMEZONE

Closes #49

abhijoshi2k · 2021-05-22T12:24:27Z

@Andre601 We'll be good to resolve #49 after you update changelog.

PuneetGopinath · 2021-05-22T15:30:18Z

I will test this branch in https://github.com/PuneetGopinath/activity-test now.

PuneetGopinath · 2021-05-22T15:36:04Z

@abhijoshi2k See those results in https://github.com/PuneetGopinath/activity-test/actions/runs/866856864
They passed, so I think this pr is ready for review

PuneetGopinath · 2021-05-22T15:37:47Z

@abhijoshi2k Is there something you want to still commit in the timezone-fix branch?

abhijoshi2k · 2021-05-22T15:39:02Z

@abhijoshi2k Is there something you want to still commit in the timezone-fix branch?

Changelog is still left

abhijoshi2k · 2021-05-22T15:45:20Z

@PuneetGopinath let us stop all the work on #53 till this pr is merged and all conflicts are resolved.

PuneetGopinath · 2021-05-22T15:51:12Z

@abhijoshi2k Why do we have to release minor version can't we release a new major version, v1.3.0 of our release has not followed semantic version already, can I update the Changelog and the draft release?

abhijoshi2k · 2021-05-22T15:52:41Z

@abhijoshi2k Why do we have to release minor version can't we release a new major version, v1.3.0 of our release has not followed semantic version already, can I update the Changelog and the draft release?

Yes, we can go for v2.0.0 in next release

PuneetGopinath · 2021-05-22T15:55:43Z

That's not how semantic versioning works imo.
1.4.0 is perfectly fine...

How?

PuneetGopinath · 2021-05-22T15:56:24Z

Semver says to use a new major version when there is a breaking change.

PuneetGopinath · 2021-05-22T16:04:01Z

I dislike that we delete the old changelog.
This goes completely against the purpose of a ChangeLOG

No, we should reset it when a new major version is released, that's why in the old format, I added the older changelogs section but you removed it!!
EDIT: Many folks consider to remove it when a new minor version is released

abhijoshi2k · 2021-05-22T16:07:05Z

@PuneetGopinath @Andre601 can we keep changelogs of old version in separate folder then?

PuneetGopinath · 2021-05-22T16:08:21Z

@PuneetGopinath @Andre601 can we keep changelogs of old version in separate folder then?

Yes, we can keep them, anyway they are available in the v1.3.0 tag

github-actions · 2021-05-22T16:13:29Z

The Pull request of @abhijoshi2k has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

abhijoshi2k · 2021-05-22T16:15:49Z

At least do that and link to it in the current change log...
But whatever. I don't have anything to do here anymore, since you two took over my only purpose here. So do wtf you want Idc anymore.

There's no need to get angry @Andre601 .
Let's work as a team. I don't think getting angry and exiting is a solution here. Mistakes do happen. Let's be considerate. 😊

Andre601 · 2021-05-22T16:19:55Z

Just make a backup of the old (v1) changelog now... Maybe in a .github/archives folder and named CHANGELOG_v1.md
That's all I ask for now.

abhijoshi2k · 2021-05-22T16:20:03Z

I hurried because, am going to sleep

I shall merge it after we clear everything with @Andre601 . I don't want to hurt a team member here. I shall also resolve all the conflicts. You can sleep.

PuneetGopinath · 2021-05-22T16:21:53Z

Just make a backup of the old (v1) changelog now... Maybe in a .github/archives folder and named CHANGELOG_v1.md
That's all I ask for now.

@abhijoshi2k You can get the old change log from the old changelogs section, then copy the raw content and create a new file and paste the content.

abhijoshi2k · 2021-05-22T16:22:21Z

At least do that and link to it in the current change log...
But whatever. I don't have anything to do here anymore, since you two took over my only purpose here. So do wtf you want Idc anymore.

Don't become angery 😆

I am.
I work more than enough with projects who use semantic versioning and now you come here and essentially piss on this.
I never in my life saw any project that jumps to a new major version for some feature changes. So far I only saw actual major changes happening on entire recodes of the code. Everything else at most caused a minor change.

The actual, true semantic versioning is major.minor.patch_build where major is for recodes/extreme code changes, minor for changes without backwards compatibility, patch for changes with backwards compatibility and build for bug fixes and similar.

See for example JDA

It's just annoying that I'm here for README and CHANGELOG changes, yet you two take this over now and I get the back seat and reviewer role...

@PuneetGopinath let's make sure this doesn't happen anymore.
@Andre601 I'm sorry that this happened.
Let's put it in past and start fresh.
I hope you understand.

PuneetGopinath · 2021-05-22T16:23:44Z

@abhijoshi2k We have breaking changes and that should release a new major version

Make a proper archive of old changelog

Andre601 · 2021-05-22T16:52:09Z

I merged a .github/changelogs/CHANGELOG_v1.md file into this branch now.

StevenJDH · 2021-05-22T17:54:47Z

At least do that and link to it in the current change log...
But whatever. I don't have anything to do here anymore, since you two took over my only purpose here. So do wtf you want Idc anymore.

Don't become angery 😆

I am.
I work more than enough with projects who use semantic versioning and now you come here and essentially piss on this.
I never in my life saw any project that jumps to a new major version for some feature changes. So far I only saw actual major changes happening on entire recodes of the code. Everything else at most caused a minor change.

The actual, true semantic versioning is major.minor.patch_build where major is for recodes/extreme code changes, minor for changes without backwards compatibility, patch for changes with backwards compatibility and build for bug fixes and similar.

See for example JDA

It's just annoying that I'm here for README and CHANGELOG changes, yet you two take this over now and I get the back seat and reviewer role...

Hello @Andre601, @PuneetGopinath and all, I just wanted to provide my two cents since my original ticket spurred this discussion and I don't want to see people upset on great working being done already. Debating can be a good thing and even healthy as long as no one takes it personal, and with versioning, there are always a lot of opinions. With that said, I will just share this, https://semver.org/. These are very clear guidelines, and with regards to Minor version, it says MINOR version when you add functionality in a backwards compatible manner. The key here is minor is not for breaking changes, but backwards compatible ones such as new features, or perhaps supporting new breaking changes of existing features while still supporting the old way marked as deprecated.

Keeping in mind the above, I think, at least in part, that some of the confusion is coming from releasing maybe too few breaking changes as a new version. For example, 1 breaking change causing the major version to update each time, which feels wrong as opposed to maybe 10. The discussion above seems to hover around both of these concepts. I won't say what I think is best, but I did just want to share some info in the hopes it helps work things out easier.

Thanks again everyone for your time and involvement in this.

abhijoshi2k · 2021-05-22T18:10:18Z

Hello @StevenJDH ,
Thanks for the valuable information provided by you. We will surely go through it and take proper steps.
I hope that issue you faced regarding DST has been resolved.
Also, I wish to let you know that if you are using the main branch for your workflow, please note that the file structure is going to be changed after #53 will be merged. Surely, the readme will be updated accordingly.
We will make sure we mention you here to remind whenever #53 is merged and new version is released.

Thank you.

StevenJDH · 2021-05-22T18:26:22Z

@abhijoshi2k yes, things look good. And yes, I've decided to switch from main to a version number after reconsidering my approach here. Thanks again 🙏🏽

abhijoshi2k · 2021-05-23T09:54:45Z

@StevenJDH The feature you requested is now released with v2.0.0
You can now use it with separate config file. Documentation is available here

StevenJDH · 2021-05-23T11:44:00Z

@abhijoshi2k perfect, I will upgrade today, thanks!

abhijoshi2k and others added 8 commits May 22, 2021 17:11

update appendDate.js

830748c

run build and format

ce08b10

logging appendDate.js

5d78db5

run build and format

9cfeda8

logging appendDate.js

262202f

run build and format

d5dc738

changed TIMEZONE_OFFSET to TIMEZONE

5aa5e0e

run build and format

6b028c6

abhijoshi2k added major Will be added to next major release Status: In progress This pr or issue is in progress Type: breaking This change will break previous versions Priority: medium Medium priority for this issue/pr. labels May 22, 2021

Update README.md

9a4df38

github-actions bot added the Updates: documentation Improvements or additions to documentation label May 22, 2021

update readme

f9ef42c

PuneetGopinath removed the Updates: documentation Improvements or additions to documentation label May 22, 2021

abhijoshi2k mentioned this pull request May 22, 2021

Use config file #53

Merged

7 tasks

Update CHANGELOG.md

8da046e

github-actions bot added the Updates: documentation Improvements or additions to documentation label May 22, 2021

Update CHANGELOG.md

d4729aa

This comment has been minimized.

Sign in to view

Update CHANGELOG.md

a955d18

PuneetGopinath added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels May 22, 2021

This comment has been minimized.

Sign in to view

Andre601 added 3 commits May 22, 2021 18:25

Make a proper archive of old changelog

ebbe009

link to old changelog

efcbd41

Merge pull request #55 from Readme-Workflows/fix/changelog-archive

6a068af

Make a proper archive of old changelog

Andre601 approved these changes May 22, 2021

View reviewed changes

abhijoshi2k merged commit acc39ee into main May 22, 2021

abhijoshi2k deleted the timezone-fix branch May 22, 2021 16:55

Readme-Workflows deleted a comment from Andre601 May 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Locale supported as timezone #54

Locale supported as timezone #54

abhijoshi2k commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021

abhijoshi2k commented May 22, 2021

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021

PuneetGopinath commented May 22, 2021

PuneetGopinath commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021 •

edited

Loading

This comment has been minimized.

github-actions bot commented May 22, 2021

This comment has been minimized.

abhijoshi2k commented May 22, 2021

This comment has been minimized.

This comment has been minimized.

Andre601 commented May 22, 2021

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021

Andre601 commented May 22, 2021

StevenJDH commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021 •

edited

Loading

StevenJDH commented May 22, 2021

abhijoshi2k commented May 23, 2021

StevenJDH commented May 23, 2021

Locale supported as timezone #54

Locale supported as timezone #54

Conversation

abhijoshi2k commented May 22, 2021 • edited Loading

Checks

Type of Pull request

Description

🔴🔴 Breaking Change 🔴🔴

abhijoshi2k commented May 22, 2021 • edited Loading

PuneetGopinath commented May 22, 2021 • edited Loading

PuneetGopinath commented May 22, 2021 • edited Loading

PuneetGopinath commented May 22, 2021

abhijoshi2k commented May 22, 2021

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021 • edited Loading

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021

PuneetGopinath commented May 22, 2021

PuneetGopinath commented May 22, 2021 • edited Loading

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021 • edited Loading

This comment has been minimized.

github-actions bot commented May 22, 2021

This comment has been minimized.

abhijoshi2k commented May 22, 2021

This comment has been minimized.

This comment has been minimized.

Andre601 commented May 22, 2021

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021 • edited Loading

abhijoshi2k commented May 22, 2021

PuneetGopinath commented May 22, 2021

Andre601 commented May 22, 2021

StevenJDH commented May 22, 2021 • edited Loading

abhijoshi2k commented May 22, 2021 • edited Loading

StevenJDH commented May 22, 2021

abhijoshi2k commented May 23, 2021

StevenJDH commented May 23, 2021

abhijoshi2k commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

PuneetGopinath commented May 22, 2021 •

edited

Loading

StevenJDH commented May 22, 2021 •

edited

Loading

abhijoshi2k commented May 22, 2021 •

edited

Loading