feat(dateHelpers): sw-2353 added setMillisecondsFromDate (#1342)

* dateHelpers, add milliseconds from a date * downloadHelpers, fix for revokeObjectURL
RedHatInsights · Jun 23, 2024 · be214e8 · be214e8
1 parent dda0e96
commit be214e8
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 1 deletion.
diff --git a/src/common/README.md b/src/common/README.md
@@ -30,6 +30,7 @@
     * [~setStartOfDay(date)](#Helpers.module_Dates..setStartOfDay) ⇒ <code>Date</code>
     * [~setEndOfMonth(date)](#Helpers.module_Dates..setEndOfMonth) ⇒ <code>Date</code>
     * [~setRangedDateTime(params)](#Helpers.module_Dates..setRangedDateTime) ⇒ <code>Object</code>
+    * [~setMillisecondsFromDate(params)](#Helpers.module_Dates..setMillisecondsFromDate) ⇒ <code>Date</code>
     * [~getRangedDateTime(granularity)](#Helpers.module_Dates..getRangedDateTime) ⇒ <code>Object</code>
     * [~getRangedMonthDateTime(month, defaultLocale)](#Helpers.module_Dates..getRangedMonthDateTime) ⇒ <code>Object</code> \| <code>\*</code> \| <code>undefined</code>
 
@@ -193,6 +194,29 @@ Set a date range based on a granularity type.
     </tr>  </tbody>
 </table>
 
+<a name="Helpers.module_Dates..setMillisecondsFromDate"></a>
+
+### Dates~setMillisecondsFromDate(params) ⇒ <code>Date</code>
+Set milliseconds from date. Defaults to internal current date.
+
+**Kind**: inner method of [<code>Dates</code>](#Helpers.module_Dates)  
+<table>
+  <thead>
+    <tr>
+      <th>Param</th><th>Type</th><th>Description</th>
+    </tr>
+  </thead>
+  <tbody>
+<tr>
+    <td>params</td><td><code>object</code></td><td></td>
+    </tr><tr>
+    <td>params.date</td><td><code>Date</code></td><td><p>The date to add milliseconds towards. Defaults to current date.</p>
+</td>
+    </tr><tr>
+    <td>params.ms</td><td><code>number</code></td><td></td>
+    </tr>  </tbody>
+</table>
+
 <a name="Helpers.module_Dates..getRangedDateTime"></a>
 
 ### Dates~getRangedDateTime(granularity) ⇒ <code>Object</code>

diff --git a/src/common/__tests__/__snapshots__/dateHelpers.test.js.snap b/src/common/__tests__/__snapshots__/dateHelpers.test.js.snap
@@ -1,5 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`DateHelpers should add milliseconds from date: add milliseconds 1`] = `2019-07-21T00:00:00.000Z`;
+
 exports[`DateHelpers should have specific functions: dateHelpers 1`] = `
 {
   "currentDateTime": {
@@ -27,6 +29,7 @@ exports[`DateHelpers should have specific functions: dateHelpers 1`] = `
   },
   "setEndOfDay": [Function],
   "setEndOfMonth": [Function],
+  "setMillisecondsFromDate": [Function],
   "setRangedDateTime": [Function],
   "setStartOfDay": [Function],
   "timestampDayFormats": {

diff --git a/src/common/__tests__/dateHelpers.test.js b/src/common/__tests__/dateHelpers.test.js
@@ -101,4 +101,8 @@ describe('DateHelpers', () => {
 
     expect(dateHelpers.setEndOfMonth(startDate).getTime()).toEqual(expectedDate.getTime());
   });
+
+  it('should add milliseconds from date', () => {
+    expect(dateHelpers.setMillisecondsFromDate({ ms: 86400000 })).toMatchSnapshot('add milliseconds');
+  });
 });
diff --git a/src/common/dateHelpers.js b/src/common/dateHelpers.js
@@ -83,6 +83,17 @@ const setRangedDateTime = ({ date = getCurrentDate(), subtract = 0, measurement
   }
 };
 
+/**
+ * Set milliseconds from date. Defaults to internal current date.
+ *
+ * @param {object} params
+ * @param {Date} params.date The date to add milliseconds towards. Defaults to current date.
+ * @param {number} params.ms
+ * @returns {Date}
+ */
+const setMillisecondsFromDate = ({ date = getCurrentDate(), ms = 0 } = {}) =>
+  new Date(new Date(date).setUTCMilliseconds(ms));
+
 /**
  * Generates the date range, starting at the beginning of getCurrentDate, and ending at the end of getCurrentDate.
  *
@@ -288,6 +299,7 @@ const dateHelpers = {
   setStartOfDay,
   setEndOfDay,
   setEndOfMonth,
+  setMillisecondsFromDate,
   getRangedMonthDateTime,
   getRangedDateTime,
   setRangedDateTime,
@@ -310,6 +322,7 @@ export {
   setStartOfDay,
   setEndOfDay,
   setEndOfMonth,
+  setMillisecondsFromDate,
   getRangedMonthDateTime,
   getRangedDateTime,
   setRangedDateTime,

diff --git a/src/common/downloadHelpers.js b/src/common/downloadHelpers.js
@@ -38,8 +38,8 @@ const downloadData = options => {
         anchorTag.click();
 
         setTimeout(() => {
+          URL.revokeObjectURL(anchorTag.href);
           document.body.removeChild(anchorTag);
-          URL.revokeObjectURL(blob);
           resolve({ fileName, data });
         }, 250);
       }