feat(dateHelpers): sw-2353 added setMillisecondsFromDate #1342
+54
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hts#1342) * dateHelpers, add milliseconds from a date * downloadHelpers, fix for revokeObjectURL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
=======================================
Coverage 91.99% 92.00%
=======================================
Files 113 113
Lines 4399 4401 +2
Branches 1857 1858 +1
=======================================
+ Hits 4047 4049 +2
Misses 332 332
Partials 20 20
Continue to review full report in Codecov by Sentry.
|
cdcabrera
force-pushed
the
sw-2353-helpers
branch
from
de51d48 to
be214e8
Compare
cdcabrera
added a commit
that referenced
this pull request
Jun 24, 2024
cdcabrera
added a commit
that referenced
this pull request
Jun 24, 2024
cdcabrera
added a commit
that referenced
this pull request
Jun 24, 2024
* dateHelpers, add milliseconds from a date * downloadHelpers, fix for revokeObjectURL
cdcabrera
added a commit
that referenced
this pull request
Jun 25, 2024
cdcabrera
added a commit
that referenced
this pull request
Jun 25, 2024
* dateHelpers, add milliseconds from a date * downloadHelpers, fix for revokeObjectURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ npm install$ npm testCheck the build
$ npm install$ npm run buildExample
...
Updates issue/story
related sw-2353 #1328