Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #484

Merged
merged 2 commits into from
Oct 28, 2020
Merged

fix(build): npm updates #484

merged 2 commits into from
Oct 28, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 28, 2020

What's included

  • chore(build): npm updates
  • fix(build): npm updates

    • platform, chrome add isBeta test setup
    • select, pf random generated id prop fix

Notes

  • We're holding on upgrading React and React scripts for the moment. It took some fiddling to get it to behave with out causing testing issues. In order to avoid smashing it through our release process we'll evaluate it over the next week or so and look at upgrading in Nov.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. no errors should be present

Example

...

Updates issue/story

Ongoing

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #484 into ci will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #484      +/-   ##
==========================================
- Coverage   93.23%   93.08%   -0.16%     
==========================================
  Files          70       70              
  Lines        1863     2269     +406     
  Branches      446      756     +310     
==========================================
+ Hits         1737     2112     +375     
- Misses        108      139      +31     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/form/select.js 98.66% <ø> (-1.34%) ⬇️
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
src/components/inventoryList/inventoryList.js 90.90% <0.00%> (-3.69%) ⬇️
src/components/rhelView/rhelView.js 89.13% <0.00%> (-3.18%) ⬇️
src/components/openshiftView/openshiftView.js 92.75% <0.00%> (-3.00%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.50% <0.00%> (-2.50%) ⬇️
src/services/platformServices.js 97.67% <0.00%> (-2.33%) ⬇️
src/redux/selectors/graphCardSelectors.js 98.21% <0.00%> (-1.79%) ⬇️
src/components/graphCard/graphCardHelpers.js 98.61% <0.00%> (-1.39%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cbe76...b16918f. Read the comment docs.

* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
@cdcabrera cdcabrera merged commit 50e4d05 into RedHatInsights:ci Oct 28, 2020
cdcabrera added a commit that referenced this pull request Oct 28, 2020
cdcabrera added a commit that referenced this pull request Oct 28, 2020
cdcabrera added a commit that referenced this pull request Oct 28, 2020
* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
cdcabrera added a commit that referenced this pull request Oct 29, 2020
cdcabrera added a commit that referenced this pull request Oct 29, 2020
* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
cdcabrera added a commit that referenced this pull request Dec 2, 2020
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
cdcabrera added a commit that referenced this pull request Dec 2, 2020
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants