Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft release 1.2.0, Sync Test to Stage #480

Merged
merged 24 commits into from
Dec 2, 2020
Merged

Draft release 1.2.0, Sync Test to Stage #480

merged 24 commits into from
Dec 2, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 27, 2020

Notes

Cloud provider updates

Commits

Bug Fixes

Additional Commits #500

Features

Bug Fixes

Additional Commits #505 #509 #513

Features

Bug Fixes

Performance Improvements

  • openshiftView,rhelView: simplify displayName callback (#507) (22fa2ed)
  • rhsmServices,userServices: expose cancel options (#513) (d784aaf)

Additional Commits #518

Bug Fixes

* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #480 (79d8334) into stage (08073f0) will increase coverage by 0.19%.
The diff coverage is 95.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##            stage     #480      +/-   ##
==========================================
+ Coverage   93.23%   93.42%   +0.19%     
==========================================
  Files          70       74       +4     
  Lines        1863     2374     +511     
  Branches      448      808     +360     
==========================================
+ Hits         1737     2218     +481     
- Misses        108      138      +30     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/form/select.js 98.66% <ø> (-1.34%) ⬇️
src/components/loader/loader.js 100.00% <ø> (ø)
src/redux/selectors/graphCardSelectors.js 98.21% <ø> (-1.79%) ⬇️
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
src/components/openshiftView/openshiftView.js 93.93% <82.35%> (-1.81%) ⬇️
src/components/rhelView/rhelView.js 90.69% <82.35%> (-1.62%) ⬇️
src/components/inventoryList/inventoryList.js 90.47% <87.50%> (-4.12%) ⬇️
...c/components/inventoryList/inventoryListHelpers.js 95.89% <95.65%> (+0.14%) ⬆️
src/components/bannerMessages/bannerMessages.js 97.43% <97.43%> (ø)
src/common/dateHelpers.js 100.00% <100.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08073f0...79d8334. Read the comment docs.

* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
* inventoryList, guestsList, expand prop types, content check
* inventoryListSelectors, lowercase measurementType
* locale, measurementType strings, VM to guests
* openshiftView, rhelView, hardware to measurementType
* rhsmApiTypes, add type, expected measurementType
* rhsmServices, measurementType mock
@cdcabrera
Copy link
Member Author

cdcabrera commented Oct 29, 2020

Current proposed release schedule

  • Current merge date for this PR is planned for EST 11-03-2020 11-16-2020
  • A subsequent PR will be opened immediately once this PR is merged aiming to have this set of changes merged into Prod-stable EST 11-04-2020 11-17-2020

* inventoryList, enforce sort on specific columns
* openshiftView, rhelView, activate sorting for measurementType
* rhsmApiTypes, expand allowed sort types
@cdcabrera
Copy link
Member Author

#488 is a blocking issue

@cdcabrera cdcabrera added the blocked Prevented from continuing label Nov 3, 2020
* inventoryList, guestsList, proptype expanded, loader colWidth
* inventoryListHelpers, apply filter column widths
* loader, pass colWidth
* openshiftView, rhelView, inventory fixed column widths
* table, check for valid cell contents, proptypes
* tableSkeleton, allow fixed column widths
* styling, fix guestsList padding
@cdcabrera cdcabrera changed the title Draft release 1.1.1, Sync Test to Stage Draft release 1.2.0, Sync Test to Stage Nov 10, 2020
@ntkathole
Copy link
Member

@cdcabrera As openshift "total" type isse is resolved, consider my ACK for this release (without cloudmeter changes as of 11/111/2020).

@cdcabrera
Copy link
Member Author

As of 20201117 a release delay towards Dec 2nd had been purposed, we'll review removing the blocked status on this PR the week of Dec 2nd

@cdcabrera
Copy link
Member Author

The release plan as of 20201130 is to do an immediate PR for release 1.2.0 after this PR merges.

Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK for this release.

@cdcabrera cdcabrera removed the blocked Prevented from continuing label Dec 1, 2020
* locale, sockets, cores copy
* inventoryListHelpers, apply PF table wrappable transform
* openshiftView, rhelView, apply isWrappable to sockets, cores column
* pageLayout, allow pageMessages
* pageMessages, messaging display
* pageToolbar, alignment with pageMessages
* styling, banner messages spacing
* appMessagesSelectors, base selector
* bannerMessages, display app banner messages
* rhelView, openshiftView, apply bannerMessages display
* build, dotenv flag for recommendations link
* locale, cloud meter related banner message strings
* appMessagesSelectors, apply tally cloud meter data, mismatch
* bannerMessages, cloud meter mismatch message
* graphCardSelectors, expose cloud meter flags
* helpers, ui link for recommendations
* rhsmApiTypes, cloud meter data and mismatch flags
* rhsmServices, mock update for cloud meter data
* minHeight, restructure resize, autoUpdate as separate params
* inventoryList, refresh minHeight for first, last inventory page
* styling, reduce inventory label size, aid in paging
* dateHelpers, expose a currentDateTime range
* bannerMessages, custom API call for reports/tally
* rhsmActions, restructure for cancel id, add getMessageReports
* messagesReducer, apply getMessageReports action type to state
* appMessagesSelectors, sync state with messagesReducer
* rhsmTypes, clean up, new message reports type
* bannerMessages, query updates for banner display
* openshiftView, rhelView, pass query to banner
* appMessageSelectors, query pass-through
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants