Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Sync, Dev to Test #486

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Environment Sync, Dev to Test #486

merged 4 commits into from
Oct 29, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 28, 2020

Description

Environment sync

Commits

Bug Fixes

  1. locale issues/481 add cloud provider string (fix(locale): issues/481 add cloud provider string #482) (299a5ae)
  2. build npm updates (fix(build): npm updates #484) (c3bc786)
  3. inventoryList issues/468 display measurementType (fix(inventoryList): issues/468 display measurementType #485) (60c5c5c)

Chores

  1. build npm updates (fix(build): npm updates #484) (0e3a755)

Notes

  • NPM build packages
  • Use measurement type data for display under inventory "Types"

@ntkathole @jlprevatt

* platform, chrome add isBeta test setup
* select, pf random generated id prop fix
* inventoryList, guestsList, expand prop types, content check
* inventoryListSelectors, lowercase measurementType
* locale, measurementType strings, VM to guests
* openshiftView, rhelView, hardware to measurementType
* rhsmApiTypes, add type, expected measurementType
* rhsmServices, measurementType mock
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #486 into qa will increase coverage by 0.00%.
The diff coverage is 88.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##               qa     #486   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          70       70           
  Lines        2269     2270    +1     
  Branches      756      761    +5     
=======================================
+ Hits         2112     2113    +1     
  Misses        139      139           
  Partials       18       18           
Impacted Files Coverage Δ
src/components/form/select.js 98.66% <ø> (ø)
src/components/guestsList/guestsList.js 98.41% <ø> (ø)
src/components/inventoryList/inventoryList.js 90.90% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
src/components/openshiftView/openshiftView.js 92.75% <87.50%> (ø)
src/components/rhelView/rhelView.js 89.13% <87.50%> (ø)
src/redux/selectors/inventoryListSelectors.js 97.56% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d0793...60c5c5c. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review October 28, 2020 21:04
@cdcabrera cdcabrera merged commit c4dbf52 into qa Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants