-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(productViewMissing): ent-3913 apply platform appNavClick #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
added
bug
Something isn't working
tech debt
We've ignored it this long...
202108
project phase
labels
Jun 2, 2021
cdcabrera
changed the title
fix(productViewMissing): ent-3913 apply platform appNavClick
fix(productViewMissing): ent-3833 apply platform appNavClick
Jun 2, 2021
cdcabrera
changed the title
fix(productViewMissing): ent-3833 apply platform appNavClick
fix(productViewMissing): ent-3913 apply platform appNavClick
Jun 2, 2021
cdcabrera
commented
Jun 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor update
* testing, window.replace noop * authentication, remove isRedirect * productViewMissing, on available product cards redirect * redirect, restructure, force a path, pass search, hash * router, var rename, centralize exports, index.js * routerHelpers, optional chain
…nsights#695) * testing, mock appNavClick, hook * productViewMissing, useRouter, setAppNav * platformActions, expose setAppNav * platformServices, expose appNavClick, replace navigation * useRouter, pass useHistory, proxy useHistory push, setAppNav
cdcabrera
added a commit
that referenced
this pull request
Jun 7, 2021
* testing, window.replace noop * authentication, remove isRedirect * productViewMissing, on available product cards redirect * redirect, restructure, force a path, pass search, hash * router, var rename, centralize exports, index.js * routerHelpers, optional chain
cdcabrera
added a commit
that referenced
this pull request
Jun 10, 2021
* testing, window.replace noop * authentication, remove isRedirect * productViewMissing, on available product cards redirect * redirect, restructure, force a path, pass search, hash * router, var rename, centralize exports, index.js * routerHelpers, optional chain
cdcabrera
added a commit
that referenced
this pull request
Jun 10, 2021
* testing, mock appNavClick, hook * productViewMissing, useRouter, setAppNav * platformActions, expose setAppNav * platformServices, expose appNavClick, replace navigation * useRouter, pass useHistory, proxy useHistory push, setAppNav
cdcabrera
added a commit
that referenced
this pull request
Jul 13, 2021
* testing, window.replace noop * authentication, remove isRedirect * productViewMissing, on available product cards redirect * redirect, restructure, force a path, pass search, hash * router, var rename, centralize exports, index.js * routerHelpers, optional chain
cdcabrera
added a commit
that referenced
this pull request
Jul 13, 2021
* testing, mock appNavClick, hook * productViewMissing, useRouter, setAppNav * platformActions, expose setAppNav * platformServices, expose appNavClick, replace navigation * useRouter, pass useHistory, proxy useHistory push, setAppNav
cdcabrera
added a commit
that referenced
this pull request
Jul 13, 2021
* testing, window.replace noop * authentication, remove isRedirect * productViewMissing, on available product cards redirect * redirect, restructure, force a path, pass search, hash * router, var rename, centralize exports, index.js * routerHelpers, optional chain
cdcabrera
added a commit
that referenced
this pull request
Jul 13, 2021
* testing, mock appNavClick, hook * productViewMissing, useRouter, setAppNav * platformActions, expose setAppNav * platformServices, expose appNavClick, replace navigation * useRouter, pass useHistory, proxy useHistory push, setAppNav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
window.location.href
appNavClick
chrome method (allows updating the left hand nav without forcing a refresh)How to test
Proxy run check
since the platform still appears to have some redirects in place, and this automagically performs the redirect you can test 2 ways to confirm it's actually doing something.
First
$ yarn
$ yarn start:proxy
/beta/subscriptions/
and confirm that the product idrhel
is used and the end result is/beta/subscriptions/rhel
Second
$ yarn
$ yarn start:proxy
/beta/subscriptions/
./src/components/productViewMissing.js
file default propavailableProductsRedirect
to zero, hit refresh and the card view of missing products should appearExample
Jun-10-2021.11-36-51.mp4
Updates issue/story
ent-3913
ent-3833