Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Sync, Dev to Test #705

Merged
merged 23 commits into from
Jun 10, 2021
Merged

Environment Sync, Dev to Test #705

merged 23 commits into from
Jun 10, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 10, 2021 •
edited
Loading

What's included

Environment Sync, Dev to Test

Commits

Code Refactoring

  1. config ent-2745 consolidate nav, routing configs (refactor(config): ent-2745 consolidate nav, routing configs #656) (4161cdf)
  2. routerHelpers ent-2745 consolidate nav, route lookup (refactor(config): ent-2745 consolidate nav, routing configs #656) (c18a3a9)
  3. productViewMissing ent-2745 use route helper (refactor(config): ent-2745 consolidate nav, routing configs #656) (ae3b538)
  4. router ent-2745 convert class component (refactor(config): ent-2745 consolidate nav, routing configs #656) (7cc2f6c)
  5. router ent-2745 function, hook convert (refactor(router): ent-2745 function, hook convert #684) (e8e07d0)

Bug Fixes

  1. testing outside src import, unit test locale (fix(testing): mock window location, components with hooks #680) (c0ad35d)
  2. testing mock window location, components with hooks (fix(testing): mock window location, components with hooks #680) (090eb45)
  3. routes,router ent-2745 dynamic lazy load views (fix(routes,router): ent-2745 dynamic lazy load views  #679) (8030765)
  4. build npm updates (fix(build): npm updates #685) (26fc935)
  5. select,toolbarFields ent-3879 apply test attributes (fix(select,toolbarFields): ent-3879 apply test attributes #687) (a823498)
  6. redirect ent-3916 route config, dynamic loading (fix(redirect): ent-3916 route config, dynamic loading #691) (a38e52b)
  7. authentication remove test block (fix(redirect): ent-3916 route config, dynamic loading #691) (9d30e74)
  8. productView ent-3888 use meta to display total core hours (fix(productView): ent-3888 use meta to display total core hours #692) (c484066)
  9. redirect ent-3833 restructure, force a path (fix(productViewMissing): ent-3913 apply platform appNavClick #695) (a9601f4)
  10. productViewMissing ent-3913 apply platform appNavClick (fix(productViewMissing): ent-3913 apply platform appNavClick #695) (6605b93)
  11. i18n allow multi-context (fix(i18n): allow multi-context #699) (afcf623)

Chores

  1. deps-dev bump apidoc-mock from 3.0.4 to 4.0.0 (chore(deps-dev): bump apidoc-mock from 3.0.4 to 4.0.0 #681) (2f6178f)
  2. deps bump victory-create-container from 35.8.0 to 35.8.1 (chore(deps): bump victory-create-container from 35.8.0 to 35.8.1 #686) (177c52e)
  3. deps-dev bump eslint-plugin-jsdoc from 35.0.0 to 35.1.3 (chore(deps-dev): bump eslint-plugin-jsdoc from 35.0.0 to 35.1.3 #696) (8bae02a)
  4. deps-dev bump eslint-plugin-import from 2.23.3 to 2.23.4 (chore(deps-dev): bump eslint-plugin-import from 2.23.3 to 2.23.4 #700) (42f993a)
  5. deps-dev bump eslint-plugin-react from 7.23.2 to 7.24.0 (chore(deps-dev): bump eslint-plugin-react from 7.23.2 to 7.24.0 #701) (75c0488)
  6. build npm updates (chore(build): npm updates #704) (418fe23)

Reverts

  1. testing outside src import, unit test locale (fix(redirect): ent-3916 route config, dynamic loading #691) (a63f6ff)

cdcabrera and others added 22 commits May 18, 2021 11:41
@cdcabrera
refactor(config): ent-2745 consolidate nav, routing configs (#656)
4161cdf 
* routerConfig, move const to routerHelpers, clean up comps and redux refs
* routerHelpers, generate nav, route, product groups, add routerConfig const
@cdcabrera
refactor(routerHelpers): ent-2745 consolidate nav, route lookup (#656)
c18a3a9 
* productViewMissing, switch to route config, allow alias matching
* router, switch to combined nav route detail lookup
* routerHelpers, consolidate nav, route lookup, clean up
@cdcabrera
refactor(productViewMissing): ent-2745 use route helper (#656)
ae3b538
@cdcabrera
refactor(router): ent-2745 convert class component (#656)
7cc2f6c 
* router, convert from class component, only allow render
* routerHelpers, remove render
@cdcabrera
fix(testing): outside src import, unit test locale (#680)
c0ad35d 
* build, package apply locale as dev dependency
* i18n, import locale
@cdcabrera
fix(testing): mock window location, components with hooks (#680)
090eb45 
* i18n remove load hook comp
* tests, mock window location
@dependabot
chore(deps-dev): bump apidoc-mock from 3.0.4 to 4.0.0 (#681)
2f6178f
@cdcabrera
refactor(router): ent-2745 function, hook convert (#684)
e8e07d0
@cdcabrera
fix(routes,router): ent-2745 dynamic lazy load views (#679)
8030765 
* routes, component views to file paths
* router, restructure for lazy load of views
@cdcabrera
fix(build): npm updates (#685)
26fc935 
* build, lint, test update
* docs, contributing
@cdcabrera
fix(select,toolbarFields): ent-3879 apply test attributes (#687)
a823498 
* select, allow data- attributes
* toolbarFields, apply test attributes
@dependabot
chore(deps): bump victory-create-container from 35.8.0 to 35.8.1 (#686)
177c52e
@cdcabrera
revert(testing): outside src import, unit test locale (#691)
a63f6ff 
* build, package remove locale as dev dependency
* i18n, revert towards require locale
@cdcabrera
fix(redirect): ent-3916 route config, dynamic loading (#691)
a38e52b
@cdcabrera
fix(authentication): remove test block (#691)
9d30e74
@cdcabrera
fix(productView): ent-3888 use meta to display total core hours (#692)
c484066 
* graphCard, pass meta for setting actions callback
* graphCardSelectors, pass normalized meta
* productView, OpenShiftContainer, Dedicated, total core hours
* rhsmServices, API mock
@cdcabrera
fix(redirect): ent-3833 restructure, force a path (#695)
a9601f4 
* testing, window.replace noop
* authentication, remove isRedirect
* productViewMissing, on available product cards redirect
* redirect, restructure, force a path, pass search, hash
* router, var rename, centralize exports, index.js
* routerHelpers, optional chain
@cdcabrera
fix(productViewMissing): ent-3913 apply platform appNavClick (#695)
6605b93 
* testing, mock appNavClick, hook
* productViewMissing, useRouter, setAppNav
* platformActions, expose setAppNav
* platformServices, expose appNavClick, replace navigation
* useRouter, pass useHistory, proxy useHistory push, setAppNav
@dependabot
chore(deps-dev): bump eslint-plugin-jsdoc from 35.0.0 to 35.1.3 (#696)
8bae02a
@cdcabrera
fix(i18n): allow multi-context (#699)
afcf623
@dependabot
chore(deps-dev): bump eslint-plugin-import from 2.23.3 to 2.23.4 (#700)
42f993a
@dependabot
chore(deps-dev): bump eslint-plugin-react from 7.23.2 to 7.24.0 (#701)
75c0488
@cdcabrera cdcabrera added the 202108 project phase label Jun 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #705 (418fe23) into qa (ebba9ab) will increase coverage by 1.09%.
The diff coverage is 97.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #705      +/-   ##
==========================================
+ Coverage   93.72%   94.82%   +1.09%     
==========================================
  Files          87       89       +2     
  Lines        2646     2684      +38     
  Branches      927      950      +23     
==========================================
+ Hits         2480     2545      +65     
+ Misses        142      118      -24     
+ Partials       24       21       -3
Impacted Files Coverage Δ
src/components/toolbar/toolbarFieldDisplayName.js 91.66% <ø> (ø)
src/components/toolbar/toolbarFieldGranularity.js 90.90% <ø> (ø)
...rc/components/toolbar/toolbarFieldRangedMonthly.js 100.00% <ø> (ø)
src/components/toolbar/toolbarFieldUom.js 100.00% <ø> (ø)
src/redux/selectors/userSelectors.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/services/userServices.js 97.22% <ø> (ø)
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
src/components/authentication/authentication.js 73.80% <66.66%> (+1.08%) ⬆️
src/components/i18n/i18n.js 83.87% <66.66%> (+1.72%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebba9ab...418fe23. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review June 10, 2021 06:24
@cdcabrera cdcabrera merged commit fc95651 into qa Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202108 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter