Draft Release 1.6.1, Sync Test to Stage #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* routerConfig, move const to routerHelpers, clean up comps and redux refs * routerHelpers, generate nav, route, product groups, add routerConfig const
* productViewMissing, switch to route config, allow alias matching * router, switch to combined nav route detail lookup * routerHelpers, consolidate nav, route lookup, clean up
* router, convert from class component, only allow render * routerHelpers, remove render
* build, package apply locale as dev dependency * i18n, import locale
* i18n remove load hook comp * tests, mock window location
* routes, component views to file paths * router, restructure for lazy load of views
* build, lint, test update * docs, contributing
* select, allow data- attributes * toolbarFields, apply test attributes
* build, package remove locale as dev dependency * i18n, revert towards require locale
* graphCard, pass meta for setting actions callback * graphCardSelectors, pass normalized meta * productView, OpenShiftContainer, Dedicated, total core hours * rhsmServices, API mock
* testing, window.replace noop * authentication, remove isRedirect * productViewMissing, on available product cards redirect * redirect, restructure, force a path, pass search, hash * router, var rename, centralize exports, index.js * routerHelpers, optional chain
* testing, mock appNavClick, hook * productViewMissing, useRouter, setAppNav * platformActions, expose setAppNav * platformServices, expose appNavClick, replace navigation * useRouter, pass useHistory, proxy useHistory push, setAppNav
Codecov Report
@@ Coverage Diff @@
## stage #707 +/- ##
==========================================
+ Coverage 93.72% 94.82% +1.09%
==========================================
Files 87 89 +2
Lines 2646 2684 +38
Branches 927 950 +23
==========================================
+ Hits 2480 2545 +65
+ Misses 142 118 -24
+ Partials 24 21 -3
Continue to review full report at Codecov.
|
|
Can we do it already? I See ENT-3818 is not yet deployed to prod. And if backend is not deployed first, there will be no "core hours" label at all, which would be a regression from user point of view. Otherwise, these changes look fine. |
jlprevatt
approved these changes
Jun 11, 2021
|
@mirekdlugosz you are correct we're delaying this PR until "total core hours" is moved to prod on the API side |
mirekdlugosz
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Since ent-3818 has been deployed to prod recently (I can see total_core_hours in meta of tally OpenShift-metrics response), I believe we can go ahead with deployment of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
Draft 1.6.1 GUI release
Notes
Commits
Bug Fixes
Code Refactoring