refactor(graphCard): sw-923 allow nested graph configs #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
sw-923
branch
2 times, most recently
from
c6f981a to
35f1ced
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1073 +/- ##
==========================================
- Coverage 93.51% 93.50% -0.01%
==========================================
Files 123 123
Lines 4118 4128 +10
Branches 1678 1681 +3
==========================================
+ Hits 3851 3860 +9
- Misses 249 250 +1
Partials 18 18
Continue to review full report at Codecov.
|
cdcabrera
commented
Mar 7, 2023
There was a problem hiding this comment.
Looks like we need to confirm any related components, hooks, that are pulling graph configuration. During review we came across
src/components/toolbar/toolbarFieldCategory.js
... using the graph config to generate the "category" / "type" options used as a filter.
src/components/graphCard/__tests__/__snapshots__/graphCardContext.test.js.snap
Outdated
Show resolved
Hide resolved
cdcabrera
force-pushed
the
sw-923
branch
2 times, most recently
from
a626634 to
569f2a3
Compare
* config, products, isMetricDisplay, nested chart groups * graphCard, isMetricDisplay setting * graphCardChart, remove isStandalone, useProduct hook * graphCardChartTitleTooltip, stringId, remove hook * graphCardContext, return single list of settings * graphCardHelpers, restructure for nested chart groups * graphCardMetricTotals, alias id to chartId * productViewContext, uom filter on nested chart groups * styling, adjust grouped chart margins * toolbarFieldCategory, generate opts, chart groups
|
/retest |
cdcabrera
added a commit
that referenced
this pull request
Mar 21, 2023
* config, products, isMetricDisplay, nested chart groups * graphCard, isMetricDisplay setting * graphCardChart, remove isStandalone, useProduct hook * graphCardChartTitleTooltip, stringId, remove hook * graphCardContext, return single list of settings * graphCardHelpers, restructure for nested chart groups * graphCardMetricTotals, alias id to chartId * productViewContext, uom filter on nested chart groups * styling, adjust grouped chart margins * toolbarFieldCategory, generate opts, chart groups
cdcabrera
added a commit
that referenced
this pull request
Apr 6, 2023
* config, products, isMetricDisplay, nested chart groups * graphCard, isMetricDisplay setting * graphCardChart, remove isStandalone, useProduct hook * graphCardChartTitleTooltip, stringId, remove hook * graphCardContext, return single list of settings * graphCardHelpers, restructure for nested chart groups * graphCardMetricTotals, alias id to chartId * productViewContext, uom filter on nested chart groups * styling, adjust grouped chart margins * toolbarFieldCategory, generate opts, chart groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Example
Updates issue/story
sw-923